[Tooling] Fix the bundler/rake failure on CI #14082
Conversation
AliSoftware
requested review from
jkmassel,
loremattei and
oguzkocer
and removed request for
a team
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APK here. |
|
After multiple attempts and debugging, it happens that the solution is to update This is because CircleCI has updated their image to use Bundle bundler 2.2.10 also generates a different |
…se the rubygems.org source
|
After reading in more details the whole PR on bundler about this security issue, I realized that with the setup we had made bundler still use the multi-source mode, because the plugin we include in Explanations of that side-effect issue
In fact, as discussed in this comment on the PR, when resolving transitive dependencies it will use the source of the parent gem, but in the case of our Only figured that out while trying to replicate the fix on WCAndroid in woocommerce/woocommerce-android#3585 – so now we use a single global Pfew 😓 I hope that's it this time |
AliSoftware
changed the title
|
| - checkout-submodules | ||
| - bundle-install/bundle-install: | ||
| cache_key_prefix: installable-build-v2 | ||
| cache_key_prefix: release-build-v2 |
| - checkout-submodules | ||
| - bundle-install/bundle-install: | ||
| cache_key_prefix: installable-build-v2 | ||
| cache_key_prefix: translation-review-build-v2 |
* Only enable the audio block on premium plans. * Sync enable/disable audio block logic with iOS. Made it clearer. * Using clear instead of setting text to empty string * Adding textEmailAddress to EditText inputType * Fix crash on snackbar display * Invalidate bundler cache to fix CI failure * Attempt to fix the CI bundler/rake cache failure again * bundle update, to rebuild the Gemfile snapshot * Invalidate checksum-less cache key again * Update to bundler 2.2.10 (security fix) and bundle update google-cloud-storage to fix resolution * Cherrypicking fix for CI bundler/rake cache failure from #14082 * Attempt to fix the CI bundler/rake cache failure again * bundle update, to rebuild the Gemfile snapshot * Invalidate checksum-less cache key again * Update to bundler 2.2.10 (security fix) and bundle update google-cloud-storage to fix resolution * Stop using multi-source mode - so that the release-toolkit gem also use the rubygems.org source * Update Bundler + Fix Gemfile * Updates gutenerg-mobile reference to 1.47.0
This is the second attempt at #14080 as it seems the fix wasn't sufficient and was merged too soon (before we finished testing the fix on the other PRs)
Hopefully that failure was only because the builds were racing each other as it seems like cache got picked by 2nd PR before 1st PR finished building it. So hopefully waiting until the job is done this time will help. I also used different cache keys for the different jobs just to be on the safe side.In fact the issue was deeper than this, see comments below and also complementary details in the WCAndroid PR doing the same on WooTo test:
PR created as Draft to be sure to not merge it too fast this time