Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jul 8, 2021

This updates the Global styles endpoint to use the non-experimental paths for fetching the block editor settings.

📓 Note that the Jetpack side is still dependent on some backend changes so this PR is still a draft.

WordPress-FluxC-Android PR: wordpress-mobile/WordPress-FluxC-Android#2049

To test:

For each of these cases, it'll be enough to open the editor and validate that the correct color options are available. It would also be useful to test using a network monitoring tool to make sure the correct paths are called. This will help ensure you aren't seeing cached data if you're reusing the same site for testing.

  • Self-Hosted Site with WP 5.8 and base Gutenberg version
    • Expect the request to be made with __experimental/wp-block-editor/v1
  • Self-Hosted Site with WP 5.8 and Gutenberg version >= 11.1
    • Expect the request to be made with /wp-block-editor/v1
  • WPCom or Jetpack connected site with WP 5.8 and base Gutenberg version
    • Expect the request to be made with __experimental/wp-block-editor/v1
  • WPCom or Jetpack connected site with WP 5.8 and Gutenberg version >= 11.1
    • Expect the request to be made with /wp-block-editor/v1

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    Check WordPress-FluxC-Android PR

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 8, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 8, 2021

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis marked this pull request as ready for review July 13, 2021 11:53
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonis antonis merged commit 169f244 into develop Jul 15, 2021
@antonis antonis deleted the issue/gssRemoveExperimentalPath branch July 15, 2021 06:09
@antonis antonis mentioned this pull request Jul 21, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants