Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Aug 4, 2021

Description:

This enables Global Style Support for FSE sites introduced with #15050 and temporarily disabled with #15058.
A full clean up of the configuration will be performed with #15132

To test:
Check instructions in #15050

Regression Notes

  1. Potential unintended areas of impact
    This is making the feature added in Update Global Styles endpoint to support non-experimental paths #15002 available to everyone.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    Verify that the existing test pass

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 4, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@antonis antonis requested a review from chipsnyder August 4, 2021 12:17
@antonis antonis marked this pull request as ready for review August 4, 2021 12:17
@antonis antonis added this to the 18.0 milestone Aug 4, 2021
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis modified the milestones: 18.0, 18.1 Aug 5, 2021
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@antonis antonis enabled auto-merge August 6, 2021 07:37
@antonis antonis merged commit f140203 into develop Aug 6, 2021
@antonis antonis deleted the rnmobile/gss/reenable branch August 6, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants