Fix editor_session_start event customer property key #15308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APKs: |
3 tasks
dcalhoun
approved these changes
Sep 9, 2021
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
LGTM. Verified the event arrived in Tracks with the expected properties, including unstable_gallery_with_image_blocks, using a Samsung Galaxy S20.
Contributor
Author
|
Thank you for the prompt review @dcalhoun! I really appreciate this 🙇 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
wpandroid_editor_session_startevents were not sent to Tracks, as they were marked as invalid with the following error. This relates to changes made in #15134 and aligns with the fix applied to iOS with wordpress-mobile/WordPress-iOS#17130To test:
18.2beta build.wpandroid_editor_session_startevent does not arrive to Tracks.wpandroid_editor_session_startevent arrives to Tracks with expected properties.Regression Notes
Potential unintended areas of impact
Custom properties for the event are missing.
What I did to test those areas of impact (or what existing automated tests I relied on)
Verified custom properties arrived with the event in Tracks.
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.