-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Gallery Refactor] Analytics #15134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antonis
merged 4 commits into
rnmobile/gallery-as-nested-image-blocks-editor-settings_v2
from
rnmobile/gallery_analytics
Sep 2, 2021
Merged
[Gallery Refactor] Analytics #15134
antonis
merged 4 commits into
rnmobile/gallery-as-nested-image-blocks-editor-settings_v2
from
rnmobile/gallery_analytics
Sep 2, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
…_v2' into rnmobile/gallery_analytics
mkevins
reviewed
Sep 2, 2021
WordPress/src/main/java/org/wordpress/android/ui/posts/PostEditorAnalyticsSession.java
Outdated
Show resolved
Hide resolved
mkevins
reviewed
Sep 2, 2021
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Show resolved
Hide resolved
Contributor
Author
mkevins
approved these changes
Sep 2, 2021
Contributor
mkevins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix Antonis! I tested it with the latest changes, and everything is working as expected. LGTM!
20ab311
into
rnmobile/gallery-as-nested-image-blocks-editor-settings_v2
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Depends on #15129
Description
This adds the results of the
unstableGalleryWithImageBlockssetting to theeditor_session_startevent so that we can monitor how many of our users have migrated to the new gallery refactor over time.Note: The changes match the analytics collected with wordpress-mobile/WordPress-iOS#16848
To test:
Setup
Enable Gallery Refactor
editor_session_startcontain the propertyunstableGalleryWithImageBlockswith the valuetrueDisable Gallery Refactor
editor_session_startcontain the propertyunstableGalleryWithImageBlockswith the valuefalseRegression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.