Skip to content

Conversation

@fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Mar 2, 2022

Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4615

This PR updates the Gutenberg Mobile reference to add newer versions of the following libraries, which are native dependencies of Gutenberg:

  • react-native-gesture-handler
  • react-native-reanimated

NOTE: This PR will be merged into gutenberg/1.72.0-changes branch instead of trunk due we don't know on which Gutenberg Mobile release will be incorporated, therefore all native changes should be put on hold until the next release is planned.

To test:
Follow testing instructions from WordPress/gutenberg#39098.

Regression Notes

  1. Potential unintended areas of impact
    It should only impact the editor hence, I don't foresee any potential unintended areas of impact.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot self-assigned this Mar 2, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 2, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@fluiddot
Copy link
Contributor Author

fluiddot commented Mar 2, 2022

The installable build is failing with error:

com.android.builder.merge.DuplicateRelativeFileException: 2 files found with path 'META-INF/android_release.kotlin_module' from inputs:
 - /home/circleci/.gradle/caches/transforms-3/63499ff81905d2beb7965dc9be162577/transformed/jetified-react-native-webview-11.6.5-wp-2/jars/classes.jar
 - /home/circleci/.gradle/caches/transforms-3/371cd8dcee3a4e77bea6ba41287d0d76/transformed/jetified-react-native-gesture-handler-2.2.0-wp-2/jars/classes.jar

Looks like we'd have to exclude the file META-INF/android_release.kotlin_module when packaging both react-native-webview and react-native-gesture-handler libraries.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 2, 2022

You can test the changes on this Pull Request by downloading the APKs:

@fluiddot fluiddot marked this pull request as ready for review March 2, 2022 16:08
@fluiddot fluiddot requested a review from geriux March 2, 2022 16:08
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So cool to see this working! I tested this following the instructions from the Gutenberg PR description and its looking good 👏 nice work!

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@fluiddot fluiddot merged commit 93184c3 into gutenberg/1.72.0-changes Mar 15, 2022
@fluiddot fluiddot deleted the gutenberg/drag-and-drop/update-gesture-and-animation-deps branch March 15, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants