Skip to content
This repository was archived by the owner on Jul 27, 2023. It is now read-only.

Conversation

@fluiddot
Copy link

@fluiddot fluiddot commented Mar 2, 2022

Related to wordpress-mobile/WordPress-Android#16033 (comment), looks like other libraries might also include the file META-INF/android_release.kotlin_module, like for example react-native-webview. In order to avoid this issue, I updated the build configuration to exclude including that file.

@fluiddot fluiddot requested a review from geriux March 2, 2022 12:15
@fluiddot fluiddot self-assigned this Mar 2, 2022
@fluiddot
Copy link
Author

fluiddot commented Mar 2, 2022

As a side note, I tested this change locally building the WordPress-Android app and pointing to a published library using:

implementation 'com.github.wordpress-mobile:react-native-gesture-handler:exclude-meta-inf-file-SNAPSHOT'

Copy link

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fluiddot fluiddot merged commit 0a03958 into wp-fork Mar 2, 2022
@fluiddot fluiddot deleted the exclude-meta-inf-file branch March 2, 2022 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants