Skip to content

[Site design revamp] Remove unused string resource hpp_subtitle #16419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkevins merged 1 commit into from
Apr 28, 2022
Merged

[Site design revamp] Remove unused string resource hpp_subtitle #16419

mkevins merged 1 commit into from
Apr 28, 2022

Conversation

@ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Apr 27, 2022 •
edited
Loading

Suggestion for #16414

To test:

  • CI should be green.

Regression Notes

  1. Potential unintended areas of impact
    Build

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Searched through the code excluding strings.xml files to be sure the resource is no longer used.
    • Built the app after making this change and smoke-tested the site design picker & page layout picker.

  3. What automated tests I added (or what prevented me from doing so)
    N/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 27, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ovitrif ovitrif mentioned this pull request Apr 27, 2022
Merged
3 tasks
@ovitrif ovitrif changed the title Remove unused string res hpp_subtitle [Site design revamp] Remove unused string resource hpp_subtitle Apr 27, 2022
@ovitrif ovitrif added Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. Site Creation labels Apr 27, 2022
@ovitrif ovitrif requested review from a team and mkevins April 27, 2022 11:07
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 27, 2022

You can test the changes on this Pull Request by downloading the APKs:

@mkevins
Copy link
Contributor

mkevins commented Apr 28, 2022

Thanks for this, Ovi, I'll merge this to the parent PR. 👍

@mkevins mkevins merged commit 1d8ef0e into feature/site-design-revamp--remove-thumbnail-mode-selector Apr 28, 2022
@mkevins mkevins deleted the pr/16414-remove-unused-string-res branch April 28, 2022 00:45
@antonis antonis mentioned this pull request May 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkevins mkevins Awaiting requested review from mkevins

Assignees

No one assigned

Labels

Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. Site Creation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ovitrif @mkevins