Site Design Screen Improvements #16468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't needed for this task, but is useful to satisfy the IDE :)
Since we are removing some parts of an implementation that shares a base class with the page picker, there will be some changes needed to adapt these for the new flow. The intent with these comments is to serve as a place-holder denoting some things that need to be rewired.
…tor' into feature/site-design-revamp--remove-bottom-toolbar
…d-string-res [Site design revamp] Remove unused string resource hpp_subtitle
…tor' into feature/site-design-revamp--remove-bottom-toolbar
…evamp--remove-bottom-toolbar [Site design revamp] Remove bottom toolbar
…evamp--remove-thumbnail-mode-selector [Site design revamp] Remove thumbnail mode selector
…evamp--remove-category-filter-pills [Site Design Revamp] Remove category filter pills
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
7 tasks
antonis
added
Site Creation
and removed
[Status] Not Ready for Review
[Status] In Progress
[Status] Not Ready for Merge
Part of a WIP Feature
Generated by 🚫 dangerJS |
…mp-subtitle-margin [Site design revamp] Adds margin between recommended design title and subtitle
…mp-remove-overlay [Site design revamp] Remove selection border when collapsing themes
…evamp--fix-preview-orientation-change-bug [Site Design Revamp] Fix blank theme preview after orientation change
antonis
approved these changes
Jun 3, 2022
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
After testing the latest changes according to the test plan I'm proceeding with merging this feature 🎉
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the Site Design Screen Improvements (internal ref:
pbArwn-4jE-p2)Merged subtasks:
To test
Follow the test plan at
pc8HXX-lA-p2Regression Notes
Potential unintended areas of impact
Page Layout Picker
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and existing automated tests (
ModalLayoutPickerViewModelTest)What automated tests I added (or what prevented me from doing so)
SiteCreationMainVMTestandHomePagePickerViewModelTestSiteDesignRecommendationProviderTestPR submission checklist:
RELEASE-NOTES.txtif necessary.