[Site Design Revamp] Remove category filter pills

[ovitrif]

Fixes point D on #16392.

Removes the category filter pills on the Site design theme screen & sets the text alignment of the large "Choose a theme" title to the left.

To test:

Theme (Site Design) Picker

1. Start the site creation flow
2. Choose an Intent (or skip)
3. Choose a site name (or skip)
4. Expect to be at the site design screen

Expectations:

• The horizontal scrolling category filter pills are gone.
• The text of the large title is aligned at the left (right for RTL languages).

Page Picker

1. Navigate to the pages list
2. Tap the FAB to create a new page
3. Expect to be at the page layout picker

Expectations:

• The horizontal scrolling category filter pills are not changed.
• The text of the large title is still aligned at the center of the screen.

Regression Notes

1. Potential unintended areas of impact
   Modal layout picker (for page creation).

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manual testing to ensure there's no regression on that screen.

3. What automated tests I added (or what prevented me from doing so)
   Existing view models unit tests.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

You can test the changes on this Pull Request by downloading the APKs:

• Jetpack-pr-16428-build-122631.apk

• WordPress-pr-16428-build-122631.apk

[ovitrif]

At the moment we're waiting for feedback related to an internal comment pbArwn-4rY-p2#comment-5630, otherwise this PR is ready, not a draft.

[twstokes]

I tested with the latest build:

• ✅ The horizontal scrolling category filter pills were gone for the theme screen
• ✅ The large title was left aligned for LTR and right aligned for RTL languages for the theme screen
• ✅ The page layout picker still had the horizontally scrolling category filter pills
• ✅ The page layout picker's title was center aligned

Great work! 🎉

Two things I noticed:

1. When in landscape mode, should we still keep the collapsed title text center aligned?

2. When I was using Hebrew to test RTL languages I noticed that the thumbnails images weren't centered. I looked, but didn't see an existing WPAndroid issue for this.

[twstokes]

1. When in landscape mode, should we still keep the collapsed title text center aligned?

I've opened up a question about this to confirm. I don't it's a blocker for this PR.

Internal ref: pbArwn-4rY-p2#comment-5693

[ovitrif]

Great work! 🎉

Two things I noticed:

1. When in landscape mode, should we still keep the collapsed title text center aligned?
2. When I was using Hebrew to test RTL languages I noticed that the thumbnails images weren't centered. I looked, but didn't see an existing WPAndroid issue for this.

Thank you @twstokes for the review and for reporting the two issues.

1. For the collapsed title I'll look into fixing it.
2. For the thumbnails not being centered issue, I'll create a WPAndroid issue for it.

[ovitrif]

@twstokes I created a new issue for the bug that you reported: #16456 and I pushed the commits to align the collapsed title text to the left (textStart to work with RTL).

[twstokes]

@twstokes I created a new issue for the bug that you reported: #16456 and I pushed the commits to align the collapsed title text to the left (textStart to work with RTL).

Thank you @ovitrif!

[twstokes]

Hey @ovitrif! 👋

The collapsed title was left-aligned as expected with the recent changes. When I changed to a RTL language (Hebrew), though, the title disappeared. Is this supposed to happen?

LTR	RTL

[ovitrif]

Hey @ovitrif! 👋

The collapsed title was left-aligned as expected with the recent changes. When I changed to a RTL language (Hebrew), though, the title disappeared. Is this supposed to happen?

Definitely not, thanks for catching this 🙇 .

I'll test it a bit more. Something's off with the titles on the site creation flow screens as they disappear on tablet, but this problem that you just reported might be different. I did notice it a few times though not regularly as in this case 👍

[ovitrif]

@twstokes Is it also the same for you that in RTL languages (Hebrew) on landscape the titles for all the new Site Creation screens are not shown?

It seems to be the case for me:

Site Intent Question	Site Name	Site Theme

If that's true I'll create another issue on our board, I added one last week about the titles not being show on tablets 😓

[twstokes]

@twstokes Is it also the same for you that in RTL languages (Hebrew) on landscape the titles for all the new Site Creation screens are not shown?

Good call @ovitrif - my device matches this behavior as well. A separate issue sounds good to me, so this one is good to merge! 🚀

[ovitrif]

@twstokes I created an issue for WP-Android regarding the missing titles in RTL on Landscape: #16465.

Gotta merge this PR once the CI checks are green (flaky unit test already fixed on trunk is causing us troubles).

CI is now green 🚀