Skip to content

[Site Design Revamp] Adds recommended designs section #16486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovitrif merged 17 commits into from
May 9, 2022
Merged

[Site Design Revamp] Adds recommended designs section #16486

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b845651
Extracts default implementation for the scale property of the ThumbDi…
antonis May 6, 2022
c950f0f
Adds dimension provider for recommended designs
antonis May 6, 2022
8b3d3d7
WIP: Adds recommended designs row
antonis May 6, 2022
ceb4a36
Fixes lint issue
antonis May 6, 2022
e5128e3
Adds recommended title
antonis May 6, 2022
dfa6d16
Add id to divider view between layouts rows
ovitrif May 6, 2022
d8a612b
Add showDividers bool to layouts item view holder for showing/hiding …
ovitrif May 6, 2022
97aaf34
Hide layouts row separator on site design screen
ovitrif May 6, 2022
b596539
Merge pull request #16488 from wordpress-mobile/task/16487-hide-separ…
antonis May 6, 2022
2a1d5c1
Fixes broken tests
antonis May 6, 2022
9217d24
Workaround to prevent recyclerview from recycling rows of different size
antonis May 6, 2022
df0d9ea
Override getItemViewType to re-enable recycling
mkevins May 9, 2022
d9eef78
Merge branch 'feature/site-design-revamp' into task/16393-recommended…
antonis May 9, 2022
443e445
Minor code optimization to avoid force unwrapping
antonis May 9, 2022
d0d65f0
Extracts (dummy) recommendation logic to a separate function
antonis May 9, 2022
df5065a
Sets Blogging as the default fallback recommendation
antonis May 9, 2022
c3d5ab5
Mocks resource provider call with one parameter
antonis May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes lint issue
  • Loading branch information
@antonis
antonis committed May 6, 2022
commit ceb4a36c1bccaa3e0f1295f1cfbb0ba782b7d7ca
2 changes: 1 addition & 1 deletion ...ress/src/main/java/org/wordpress/android/ui/sitecreation/theme/HomePagePickerViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ class HomePagePickerViewModel @Inject constructor(
updateUiState(Error())
} else {
// TODO: This is just to demonstrate the UI. The real are pending to be linked
val recommended = event.categories.filter { it.slug == "blog" }.apply { }.toLayoutCategories(true)
val recommended = event.categories.filter { it.slug == "blog" }.toLayoutCategories(true)

val categories = event.categories.toLayoutCategories()
handleResponse(event.designs.toLayoutModels(), recommended + categories)
Expand Down