[Site Design Revamp] Adds recommended designs section #16486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
antonis
added
[Type] Task
Site Creation
[Status] Not Ready for Merge
Part of a WIP Feature
|
You can test the changes on this Pull Request by downloading the APKs: |
…ators [Site Design Revamp] Main View - Hide layouts row separators
mkevins
reviewed
May 9, 2022
Contributor
mkevins
left a comment
mkevins
left a comment
There was a problem hiding this comment.
This looks good and is working well for me so far in my testing. Also, the approach is reasonable, imo. I've added a suggestion for how to tackle the recycling issue for the different types of category rows.
Another alternative to consider would be to make the recommended row its own recycler view at the top level (as a preceding sibling outside of the layoutsRecyclerView).
WordPress/src/main/java/org/wordpress/android/ui/layoutpicker/LayoutCategoryAdapter.kt
Outdated
Show resolved
Hide resolved
ovitrif
reviewed
May 9, 2022
Contributor
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Code changes LGTM 🎉 !
Testing will follow 👍
Contributor
Works as expected! 🎉 @antonis Should we |
? 🚀
Contributor
Author
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16393
Description
This PR adds a larger horizontally scrolling section under the title with caption “Picked for you” to prominently present a list of recommended designs.
Note:
[Site Design Revamp] Determine recommended designs based on verticalissue.To test
Start the site creation flow and verify that the recommended section is shown
feature/site-design-revamp)Verify that the UI of the page layout picker is unchanged
feature/site-design-revamp)Regression Notes
Potential unintended areas of impact
Page Layout Picker UI
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and the existing
ModalLayoutPickerViewModelTestWhat automated tests I added (or what prevented me from doing so)
Relied/modified on existing tests
PR submission checklist:
RELEASE-NOTES.txtif necessary.