Skip to content

Conversation

@ovitrif
Copy link
Contributor

@ovitrif ovitrif commented May 6, 2022

Fixes #16487

Hides the gray lines (separators) between the categories on the Site theme screen to better align with the Android Material Design look & feel.

The Page Layout Picker (visible when creating a new page) is still showing the gray separators.

To test:

Theme Picker

  1. Start the site creation flow
  2. Pick an intent (or skip)
  3. Enter a site name (or skip)
  4. Expect to land on the theme selection screen
    • Expect no gray lines separating the rows of theme categories

Page Picker

  1. Navigate to the page list
  2. Tap the FAB to create a new page
  3. Expect to land on the layout selection screen
    • Expect gray lines separating the rows of layout categories

Previews

Theme Picker Page Picker

Regression Notes

  1. Potential unintended areas of impact
    Page layout picker.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing both the theme picker and the page layout picker.

  3. What automated tests I added (or what prevented me from doing so)
    None - the UI changes imply no unit tests coverage.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ovitrif ovitrif requested review from a team and antonis May 6, 2022 15:10
@ovitrif ovitrif self-assigned this May 6, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 6, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ovitrif ovitrif added the Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. label May 6, 2022
@ovitrif ovitrif linked an issue May 6, 2022 that may be closed by this pull request
@ovitrif ovitrif force-pushed the task/16487-hide-separators branch from a4d68a0 to 97aaf34 Compare May 6, 2022 15:19
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ovitrif 👍
The code looks good and works as expected 🎉
Thank you for handling this 🙇

@antonis antonis merged commit b596539 into task/16393-recommended-designs May 6, 2022
@antonis antonis deleted the task/16487-hide-separators branch May 6, 2022 15:23
@antonis antonis mentioned this pull request May 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Part of a WIP Feature This label is used to disable milestone checks for PRs that are not against `develop` or `release`. Site Creation [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Site Design Revamp] Main View - Hide layouts row separators

3 participants