Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented May 13, 2022

Description

Fixes crash occurring when rotating the Site Intent Question screen on the feature/site-design-revamp branch

To test:

  1. Start the site creation flow
  2. Rotate the device
  3. Verify that no crash occurs
  4. Rotate back
  5. Proceed to the Site Design screen
  6. Rotate the device
  7. Verify that the screen behaves as expected

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@antonis antonis requested a review from ovitrif May 13, 2022 15:05
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis marked this pull request as ready for review May 13, 2022 15:33
Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM & it works as expected 🎉

Thank you for fixing this so quick 🚀

@ovitrif ovitrif merged commit ad8044c into feature/site-design-revamp May 13, 2022
@ovitrif ovitrif deleted the fix/crash-on-site-intent-rotation branch May 13, 2022 16:07
@ovitrif ovitrif self-assigned this May 13, 2022
@antonis antonis mentioned this pull request May 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants