Skip to content

[Site Design Revamp] Updates the UI on vertical change #16549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ovitrif merged 2 commits into from
May 13, 2022
Merged

[Site Design Revamp] Updates the UI on vertical change #16549

ovitrif merged 2 commits into from
May 13, 2022

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented May 13, 2022 •
edited
Loading

Fixes #16540

Description

This PR updates the UI when the user revisits the Site Design screen with a different vertical selected.

To test:

  1. Start the Site Creation flow
  2. Select one of the main topics listed under the input
  3. Tap ← to go back
  4. Select another main topic
  5. Verify that the recommended section is updated.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    Added tests with 18c2ac8

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 13, 2022 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@antonis antonis marked this pull request as ready for review May 13, 2022 16:43
@antonis antonis requested review from mkevins and ovitrif May 13, 2022 16:43
@antonis antonis linked an issue May 13, 2022 that may be closed by this pull request
[Site Design Revamp] Going back from Site Theme screen and selecting another topic doesn't update the recommended section #16540
Closed
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 13, 2022

You can test the changes on this Pull Request by downloading the APKs:

ovitrif
ovitrif approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you for fixing this 🙇

@ovitrif ovitrif merged commit 89e7f74 into feature/site-design-revamp May 13, 2022
@ovitrif ovitrif deleted the fix/16540-handle-vertical-change branch May 13, 2022 19:17
@antonis antonis mentioned this pull request May 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkevins mkevins Awaiting requested review from mkevins

1 more reviewer

@ovitrif ovitrif ovitrif approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Site Creation [Type] Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Site Design Revamp] Going back from Site Theme screen and selecting another topic doesn't update the recommended section

3 participants

@antonis @ovitrif