Skip to content

[Site Creation] Fix screen titles visibility on tablet for the new & updated screens #16550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 1 commit into from
May 16, 2022
Merged

[Site Creation] Fix screen titles visibility on tablet for the new & updated screens #16550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .../main/java/org/wordpress/android/ui/sitecreation/sitename/SiteCreationSiteNameFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ class SiteCreationSiteNameFragment : Fragment() {
siteCreationSiteNameHeader.title?.text = headerTitleWithIntentColoredBlueIfSpecified
siteCreationSiteNameHeader.subtitle?.setText(R.string.new_site_creation_site_name_header_subtitle)
siteCreationSiteNameTitlebar.appBarTitle.setText(R.string.new_site_creation_site_name_title)
siteCreationSiteNameTitlebar.appBarTitle.isInvisible = !displayUtils.isPhoneLandscape()
viewModel.uiState.value?.siteName.let { input.setText(it) }
input.requestFocus()
ActivityUtils.showKeyboard(input)
Expand Down
2 changes: 0 additions & 2 deletions ...Press/src/main/java/org/wordpress/android/ui/sitecreation/theme/HomePagePickerFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.core.view.isGone
import androidx.core.view.isInvisible
import androidx.core.view.updateLayoutParams
import androidx.fragment.app.Fragment
import androidx.lifecycle.ViewModelProvider
Expand Down Expand Up @@ -87,7 +86,6 @@ class HomePagePickerFragment : Fragment() {
}

private fun HomePagePickerFragmentBinding.setupUi() {
homePagePickerTitlebar.title.isInvisible = !displayUtils.isPhoneLandscape()
with(modalLayoutPickerHeaderSection) {
modalLayoutPickerTitleRow?.header?.apply {
textAlignment = View.TEXT_ALIGNMENT_TEXT_START
Expand Down
2 changes: 0 additions & 2 deletions .../main/java/org/wordpress/android/ui/sitecreation/verticals/SiteCreationIntentsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.core.view.isInvisible
import androidx.core.view.isVisible
import androidx.core.widget.doOnTextChanged
import androidx.fragment.app.Fragment
Expand Down Expand Up @@ -68,7 +67,6 @@ class SiteCreationIntentsFragment : Fragment() {
}

private fun SiteCreationIntentsFragmentBinding.setupUi() {
siteCreationIntentsTitlebar.appBarTitle.isInvisible = !displayUtils.isPhoneLandscape()
recyclerView.itemAnimator = null
recyclerView.adapter = SiteCreationIntentsAdapter()
siteCreationIntentsHeader.title?.setText(R.string.new_site_creation_intents_header_title)
Expand Down