Skip to content

Conversation

@ovitrif
Copy link
Contributor

@ovitrif ovitrif commented May 13, 2022

Fixes #16464

Screen titles of the new and updated screens in the site creation flow were hidden on tablet.
This pull request fixes the bug by removing a line of code which apparently didn't change anything except for introducing this bug on tablets.

Preview

preview

To test:

On Tablet

  1. Start the site creation flow
    • expect the screen title Site topic to be displayed.
  2. Choose or enter a site topic
3. Optional

if SiteNameFeatureConfig is enabled via manually returning true here:

  • expect the screen title Site name to be displayed.
  • Enter a site name
  1. expect to land on the Choose a theme with the screen title displayed.

Regression Notes

  1. Potential unintended areas of impact
    All 3 affected screens (Site Topic, Site Name, Site Theme) on mobile (portrait or landscape).

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing.

  3. What automated tests I added (or what prevented me from doing so)
    N/a - Only UI changes.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @ovitrif 👍
I tested this PR on the emulator and everything worked as expected. The code changes also LGTM 🎉

@antonis antonis merged commit 0147793 into feature/site-design-revamp May 16, 2022
@antonis antonis deleted the issue/16464-site-creation-tablet-screen-titles branch May 16, 2022 13:52
@antonis antonis mentioned this pull request May 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Site Creation] Titles are not shown on tablet for the Site Intent Question, Site Name and Site Theme screens

3 participants