[Site Creation] Fix screen titles visibility on tablet for the new & updated screens #16550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16464
Screen titles of the new and updated screens in the site creation flow were hidden on tablet.
This pull request fixes the bug by removing a line of code which apparently didn't change anything except for introducing this bug on tablets.
Preview
To test:
On Tablet
Site topicto be displayed.3. Optional
if
SiteNameFeatureConfigis enabled via manually returningtruehere:Site nameto be displayed.Choose a themewith the screen title displayed.Regression Notes
Potential unintended areas of impact
All 3 affected screens (Site Topic, Site Name, Site Theme) on mobile (portrait or landscape).
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing.
What automated tests I added (or what prevented me from doing so)
N/a - Only UI changes.
PR submission checklist:
RELEASE-NOTES.txtif necessary.