-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Site Creation] Replace Dagger with Hilt for Dependency Injection #16575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Site Creation] Replace Dagger with Hilt for Dependency Injection #16575
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can test the changes on this Pull Request by downloading the APKs: |
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ovitrif 👍
I've tested on a Pixel 5/Android 12 and everything worked as expected. The code changes also look consistent to me 🎉
Thank you for improving our codebase 🙇
Closes #16574
Refactors dependency injection to use Hilt instead of Dagger for activities, fragments & view models of the Site Creation flow.
To test:
Run
optional UI/connected testsCI step (✅ Done - Green).Run the following test manual testing scenarios with exploratory touches (pressing back, changing screen orientation randomly on the screens).
If everything works as before then this PR is ok:
1. Site Name feature
off(default)Chooseon the theme preview screenCreate Site2. Site Name feature
onSiteNameFeatureConfig.isEnabled()to returntruehereCreate Siteon the theme preview screen3. Regression Testing - Page Layout Picker
PreviewCreate PageRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
Review Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.