Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented May 19, 2022

Description

Fixes a regression introduced in #16597 by setting the correct height in the Page Layout Picker skeleton view

To test:

  1. Tap the ➕ button on the My Site screen
  2. Select Site Page
  3. Rotate the device before while in the loading/skeleton view
  4. Verify no change in behaviour of this screen
Before
before.mp4
After
after.mp4

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Antonis! I've confirmed that this fixes the issue.

@mkevins mkevins merged commit ddca94e into feature/site-design-revamp May 20, 2022
@mkevins mkevins deleted the fix/site-design-skeleton-regression branch May 20, 2022 04:32
@antonis antonis mentioned this pull request May 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants