-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Site Creation] Tweak UI of Site Theme to match design specs #16619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Site Creation] Tweak UI of Site Theme to match design specs #16619
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
You can test the changes on this Pull Request by downloading the APKs: |
WordPress/src/main/java/org/wordpress/android/ui/layoutpicker/LayoutsRowViewHolder.kt
Outdated
Show resolved
Hide resolved
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ovitrif 👍
I've tested the implementation on a Pixel 5 / Android 12 and everything works as expected. The code also LGTM 🎉
I've just left a comment/suggestion but it is not blocking :)
Tweaks the UI of the Site Theme screen to match the Figma Designs:
16dp20spSmall refactoring was also added to this PR, concerning code cleanup that we identified after merging #16584
To test:
Choose a design/themescreenPreviews:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.