Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented May 24, 2022

Description

Wraps the thumbnail url String in an MShot object so that the retries are handled correctly when the server redirects to a loading gif image when the thumbnail is not ready. This is a continuation of the thumbnail preloading implementation from #16584

To test:

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 24, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@antonis antonis marked this pull request as ready for review May 24, 2022 09:31
@antonis antonis requested review from mkevins and ovitrif May 24, 2022 09:33
@antonis antonis marked this pull request as draft May 24, 2022 09:42
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@antonis antonis marked this pull request as ready for review May 24, 2022 10:08
Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 🎉 I tested this with 4 languages: NL, IT, ES and EN after clearing the app cache from settings.

Thank you @antonis for the fix 🙇

🚀

@ovitrif ovitrif merged commit 02805c6 into feature/site-design-revamp May 24, 2022
@ovitrif ovitrif deleted the task/preload-mshot branch May 24, 2022 14:46
@antonis antonis mentioned this pull request May 24, 2022
3 tasks
@mkevins
Copy link
Contributor

mkevins commented May 24, 2022

Thank you for tackling this Antonis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants