[Gutenberg] Add metadata on media upload success event #17961

fluiddot · 2023-02-15T15:49:28Z

Related PRs:

Fixes wordpress-mobile/gutenberg-mobile#5471.

Add metadata parameter to the media upload success event that is passed to the Gutenberg editor. This parameter is open to any information around the media that can be useful to have when the upload finishes successfully.

This PR also includes the VideoPress GUID to the metadata parameter as it's needed to render the VideoPress block.

To test

NOTE: This change can only be tested on development using a patch file in Gutenberg.

Apply the following patch in Gutenberg codebase:

diff --git forkSrcPrefix/packages/block-library/src/video/edit.native.js forkDstPrefix/packages/block-library/src/video/edit.native.js
index 99225ba5d5c569d19a158f5b1a203c68aa353c33..da4e3418c46305386a68ceaec618f818dc0ffb4a 100644
--- forkSrcPrefix/packages/block-library/src/video/edit.native.js
+++ forkDstPrefix/packages/block-library/src/video/edit.native.js
@@ -138,6 +138,9 @@ class VideoEdit extends Component {
 
 	finishMediaUploadWithSuccess( payload ) {
 		const { setAttributes } = this.props;
+
+		console.log( 'finishMediaUploadWithSuccess', payload );
+
 		setAttributes( { src: payload.mediaUrl, id: payload.mediaServerId } );
 		this.setState( { isUploadInProgress: false } );
 	}

Build the app and connect it with your Metro local server.
Open a post/page in a simple site.
Insert a Video block.
Upload a video from the device.
Once the upload finishes, check the console logs and observe an entry that displays the metadata and VideoPress GUID, e.g.: finishMediaUploadWithSuccess {"mediaId": <MEDIA_ID>, "mediaServerId": <MEDIA_SERVER_ID>, "mediaUrl": "https://<SITE>.files.wordpress.com/2023/02/file_example_mp4_480_1_5mg-21.mp4", "metadata": {"videopressGUID": "<VIDEOPRESS_GUID"}, "progress": 1, "state": 2}

Regression Notes

Potential unintended areas of impact
This change shouldn't produce any side effects but if any, it would affect the media uploads in the editor.
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested uploads on the different media blocks:
- Image block ✅
- Video block ✅
- Cover block ✅
- File block ✅
- Audio block ✅
What automated tests I added (or what prevented me from doing so)
N/A

PR submission checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

wpmobilebot · 2023-02-15T18:42:29Z

📲 You can test these changes on Jetpack by downloading jetpack-installable-build-pr17961-162c2e1.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`Jetpack`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`162c2e1`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

wpmobilebot · 2023-02-15T18:43:39Z

📲 You can test these changes on WordPress by downloading wordpress-installable-build-pr17961-162c2e1.apk

	💡 Scan this QR code with your Android phone to download and install the APK directly on it.
	App	`WordPress`
	Build Flavor	`Jalapeno`
	Build Type	`Debug`
	Commit	`162c2e1`

Note: This installable build uses the JalapenoDebug build flavor, and does not support Google Login.

jhnstn

Test plan worked as expected and changes look good

dcalhoun · 2023-02-23T17:35:29Z

👋🏻 @fluiddot. I encountered the following error while attempting to build WPAndroid against my local Gutenberg repository.

/WordPress-Android/libs/editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergContainerFragment.java:218: error: method mediaFileUploadSucceeded in class WPAndroidGlueCode cannot be applied to given types;
        mWPAndroidGlueCode.mediaFileUploadSucceeded(mediaId, mediaUrl, serverMediaId);
                          ^
  required: int,String,int,WritableNativeMap
  found: int,String,int
  reason: actual and formal argument lists differ in length

My understanding is that this error occurs because this PR has not yet merged integrating the now merged WordPress/gutenberg#48103. I can easily work around the issue by reverting WordPress/gutenberg@cfb54a7 locally, but wanted to call attention to the error incase this PR was overlooked.

Do we intend to merge this PR in the near future? Doing so may help others avoid this unexpected error. Thanks! 🙇🏻

fluiddot · 2023-02-23T18:04:24Z

My understanding is that this error occurs because this PR has not yet merged integrating the now merged WordPress/gutenberg#48103. I can easily work around the issue by reverting WordPress/gutenberg@cfb54a7 locally, but wanted to call attention to the error incase this PR was overlooked.

Do we intend to merge this PR in the near future? Doing so may help others avoid this unexpected error. Thanks! 🙇🏻

Yeah, sorry for that. I started the merge domino but had to pause it due to the Buildkite issues. Now that the issue is solved I'll resume it and merge the PRs 💨 .

# Conflicts: # build.gradle

fluiddot · 2023-02-23T20:40:08Z

My understanding is that this error occurs because this PR has not yet merged integrating the now merged WordPress/gutenberg#48103. I can easily work around the issue by reverting WordPress/gutenberg@cfb54a7 locally, but wanted to call attention to the error incase this PR was overlooked.
Do we intend to merge this PR in the near future? Doing so may help others avoid this unexpected error. Thanks! 🙇🏻

Yeah, sorry for that. I started the merge domino but had to pause it due to the Buildkite issues. Now that the issue is solved I'll resume it and merge the PRs 💨 .

@dcalhoun The PR is ready to be merged so I enabled auto-merge. Once the CI jobs succeed, it will be merged into trunk 🎊 .

wpmobilebot · 2023-02-23T20:45:43Z

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:editor
-|    \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.89.0
-|         +--- com.facebook.fresco:animated-gif:2.0.0
-|         |    +--- com.parse.bolts:bolts-tasks:1.4.0
-|         |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
-|         |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-|         |    \--- com.facebook.fresco:animated-base:2.0.0
-|         |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-|         |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
-|         |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-|         |         +--- com.facebook.fresco:animated-drawable:2.0.0
-|         |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
-|         |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
-|         |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
-|         |         \--- com.parse.bolts:bolts-tasks:1.4.0
-|         +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
-|         +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
-|         |    +--- com.google.android.exoplayer:exoplayer:2.13.3
-|         |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
-|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |    |    \--- com.google.guava:guava:27.1-android
-|         |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
-|         |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
-|         |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
-|         |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-|         |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
-|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
-|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
-|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
-|         |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
-|         |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
-|         |    |         \--- androidx.media:media:1.2.1 (*)
-|         |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
-|         |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
-|         |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
-|         |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
-|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|         |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
-|         |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
-|         +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
-|         +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
-|         +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
-|         +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
-|         |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
-|         +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
-|         |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
-|         |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
-|         |    +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
-|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
-|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
-|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
-|         |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
-|         |    +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
-|         |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
-|         |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
-|         |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
-|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
-|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
-|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
-|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
-|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
-|         |    +--- com.github.bumptech.glide:glide:4.12.0
-|         |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
-|         |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|         |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
-|         |    |    +--- com.github.bumptech.glide:annotations:4.12.0
-|         |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
-|         |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
-|         |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
-|         |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-|         |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
-|         |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
-|         |         \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|         +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.89.0
-|         |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-|         |    +--- androidx.gridlayout:gridlayout:1.0.0
-|         |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
-|         |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-|         |    +--- androidx.cardview:cardview:1.0.0 (*)
-|         |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
-|         |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
-|         |    +--- org.wordpress:aztec:v1.6.3 (*)
-|         |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 (*)
-|         |    +--- org.wordpress.aztec:wordpress-comments:v1.6.3 (*)
-|         |    +--- org.wordpress.aztec:glide-loader:v1.6.3
-|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
-|         |    |    +--- org.wordpress:aztec:v1.6.3 (*)
-|         |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+|    \--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.90.0-alpha1
+|         +--- com.facebook.fresco:animated-gif:2.0.0
+|         |    +--- com.parse.bolts:bolts-tasks:1.4.0
+|         |    +--- com.facebook.soloader:soloader:0.6.0 -> 0.10.4 (*)
+|         |    +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+|         |    \--- com.facebook.fresco:animated-base:2.0.0
+|         |         +--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+|         |         +--- com.facebook.fresco:imagepipeline-base:2.0.0 -> 2.5.0 (*)
+|         |         +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+|         |         +--- com.facebook.fresco:animated-drawable:2.0.0
+|         |         |    +--- com.facebook.fresco:imagepipeline:2.0.0 -> 2.5.0 (*)
+|         |         |    +--- com.facebook.fresco:drawee:2.0.0 -> 2.5.0 (*)
+|         |         |    \--- com.facebook.fresco:fbcore:2.0.0 -> 2.5.0
+|         |         \--- com.parse.bolts:bolts-tasks:1.4.0
+|         +--- com.google.android.material:material:1.2.1 -> 1.6.0-alpha01 (*)
+|         +--- com.github.wordpress-mobile:react-native-video:5.2.0-wp-5
+|         |    +--- com.google.android.exoplayer:exoplayer:2.13.3
+|         |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3
+|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3
+|         |    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |    |    \--- com.google.guava:guava:27.1-android
+|         |    |    |    |         +--- com.google.guava:failureaccess:1.0.1
+|         |    |    |    |         \--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
+|         |    |    |    \--- com.google.android.exoplayer:exoplayer-extractor:2.13.3
+|         |    |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |         \--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+|         |    |    +--- com.google.android.exoplayer:exoplayer-dash:2.13.3
+|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    +--- com.google.android.exoplayer:exoplayer-hls:2.13.3
+|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |    +--- com.google.android.exoplayer:exoplayer-smoothstreaming:2.13.3
+|         |    |    |    +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    +--- com.google.android.exoplayer:exoplayer-transformer:2.13.3
+|         |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    |    \--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |    \--- com.google.android.exoplayer:exoplayer-ui:2.13.3
+|         |    |         +--- com.google.android.exoplayer:exoplayer-core:2.13.3 (*)
+|         |    |         +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |         +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+|         |    |         \--- androidx.media:media:1.2.1 (*)
+|         |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    +--- androidx.core:core:1.1.0 -> 1.8.0 (*)
+|         |    +--- androidx.media:media:1.1.0 -> 1.2.1 (*)
+|         |    +--- com.google.android.exoplayer:extension-okhttp:2.13.3
+|         |    |    +--- com.google.android.exoplayer:exoplayer-common:2.13.3 (*)
+|         |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|         |    |    \--- com.squareup.okhttp3:okhttp:3.12.11 -> 4.9.2 (*)
+|         |    \--- com.squareup.okhttp3:okhttp:${OKHTTP_VERSION} -> 4.9.2 (*)
+|         +--- com.github.wordpress-mobile:react-native-linear-gradient:2.5.6-wp-3
+|         +--- com.github.wordpress-mobile:react-native-slider:3.0.2-wp-3
+|         +--- com.github.wordpress-mobile:react-native-reanimated:2.9.1-wp-3
+|         +--- com.github.wordpress-mobile:react-native-prompt-android:1.0.0-wp-3
+|         |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.4.2 (*)
+|         +--- com.github.wordpress-mobile:react-native-gesture-handler:2.3.2-wp-2
+|         |    +--- com.github.wordpress-mobile:react-native-reanimated:2.4.1-wp-1 -> 2.9.1-wp-3
+|         |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+|         |    +--- androidx.core:core-ktx:1.6.0 -> 1.8.0 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.20 -> 1.6.21 (*)
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-get-random-values:1.4.0
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-safe-area-context:3.2.0
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-screens:2.9.0
+|         |    +--- androidx.appcompat:appcompat:1.1.0 -> 1.4.2 (*)
+|         |    +--- androidx.fragment:fragment:1.2.1 -> 1.5.5 (*)
+|         |    +--- androidx.coordinatorlayout:coordinatorlayout:1.1.0 (*)
+|         |    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.0.0 -> 1.1.0 (*)
+|         |    \--- com.google.android.material:material:1.1.0 -> 1.6.0-alpha01 (*)
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-svg:9.13.6
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-webview:11.6.2
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.21 (*)
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-masked-view:0.2.6
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-clipboard:1.9.0
+|         +--- org.wordpress-mobile.react-native-libraries.v1:react-native-fast-image:8.5.11
+|         |    +--- com.github.bumptech.glide:glide:4.12.0
+|         |    |    +--- com.github.bumptech.glide:gifdecoder:4.12.0
+|         |    |    |    \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|         |    |    +--- com.github.bumptech.glide:disklrucache:4.12.0
+|         |    |    +--- com.github.bumptech.glide:annotations:4.12.0
+|         |    |    +--- androidx.fragment:fragment:1.0.0 -> 1.5.5 (*)
+|         |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
+|         |    |    \--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
+|         |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
+|         |         +--- com.github.bumptech.glide:glide:4.12.0 (*)
+|         |         +--- com.squareup.okhttp3:okhttp:3.9.1 -> 4.9.2 (*)
+|         |         \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|         +--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.90.0-alpha1
+|         |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+|         |    +--- androidx.gridlayout:gridlayout:1.0.0
+|         |    |    +--- androidx.core:core:1.0.0 -> 1.8.0 (*)
+|         |    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+|         |    +--- androidx.cardview:cardview:1.0.0 (*)
+|         |    +--- androidx.appcompat:appcompat:1.2.0 -> 1.4.2 (*)
+|         |    +--- androidx.recyclerview:recyclerview:1.1.0 -> 1.2.1 (*)
+|         |    +--- org.wordpress:aztec:v1.6.3 (*)
+|         |    +--- org.wordpress.aztec:wordpress-shortcodes:v1.6.3 (*)
+|         |    +--- org.wordpress.aztec:wordpress-comments:v1.6.3 (*)
+|         |    +--- org.wordpress.aztec:glide-loader:v1.6.3
+|         |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.6.21 (*)
+|         |    |    +--- org.wordpress:aztec:v1.6.3 (*)
+|         |    |    \--- com.github.bumptech.glide:glide:4.10.0 -> 4.12.0 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.21 (*)
-\--- org.wordpress:utils:{strictly 3.2.0} -> 3.2.0
+\--- org.wordpress:utils:{strictly trunk-457c978681c743506c728784ab7cd31d77a8296a} -> trunk-457c978681c743506c728784ab7cd31d77a8296a

Please review and act accordingly

fluiddot added 3 commits February 15, 2023 13:43

Add metadata param to media upload success event

3094e8f

Update WP-utils reference to PR

4e9ad66

Add videoPressGuid to metadata of media upload success event

5b4ecdc

fluiddot added the gutenberg-mobile label Feb 15, 2023

fluiddot self-assigned this Feb 15, 2023

Update Gutenberg Mobile reference

ec0b79e

fluiddot mentioned this pull request Feb 15, 2023

Add VideoPressGuid property to MediaFile wordpress-mobile/WordPress-Utils-Android#121

Merged

fluiddot marked this pull request as ready for review February 16, 2023 12:44

fluiddot added this to the 21.9 milestone Feb 16, 2023

fluiddot added 2 commits February 16, 2023 14:18

Update Gutenberg Mobile reference

4bd8b0a

Avoid null videopressGUID metadata value

32c9cee

jhnstn self-requested a review February 17, 2023 19:54

jhnstn approved these changes Feb 17, 2023

View reviewed changes

fluiddot added 3 commits February 23, 2023 20:47

Update WP-utils reference to merge commit

16951b9

Update Gutenberg Mobile reference with alpha tag

4ed7d15

Merge branch 'trunk' into gutenberg/add-media-upload-metadata

162c2e1

# Conflicts: # build.gradle

fluiddot enabled auto-merge February 23, 2023 20:38

fluiddot merged commit f660ed3 into trunk Feb 23, 2023

fluiddot deleted the gutenberg/add-media-upload-metadata branch February 23, 2023 21:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Gutenberg] Add metadata on media upload success event #17961

[Gutenberg] Add metadata on media upload success event #17961

fluiddot commented Feb 15, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 15, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Feb 15, 2023 •

edited

Loading

Uh oh!

jhnstn left a comment

Uh oh!

dcalhoun commented Feb 23, 2023

Uh oh!

fluiddot commented Feb 23, 2023

Uh oh!

fluiddot commented Feb 23, 2023

Uh oh!

wpmobilebot commented Feb 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[Gutenberg] Add metadata on media upload success event #17961

[Gutenberg] Add metadata on media upload success event #17961

Conversation

fluiddot commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To test

Regression Notes

Uh oh!

wpmobilebot commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhnstn left a comment

Choose a reason for hiding this comment

Uh oh!

dcalhoun commented Feb 23, 2023

Uh oh!

fluiddot commented Feb 23, 2023

Uh oh!

fluiddot commented Feb 23, 2023

Uh oh!

wpmobilebot commented Feb 23, 2023

The PR caused the following dependency changes:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fluiddot commented Feb 15, 2023 •

edited

Loading

wpmobilebot commented Feb 15, 2023 •

edited

Loading

wpmobilebot commented Feb 15, 2023 •

edited

Loading