-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Gutenberg] Add metadata on media upload success event #20144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2023
Merged
Merged
Contributor
You can test the changes in WordPress from this Pull Request by:
|
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
jhnstn
approved these changes
Feb 17, 2023
Member
jhnstn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test plan works as expected and changes look good. ![]()
twstokes
reviewed
Feb 17, 2023
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaInserterHelper.swift
Outdated
Show resolved
Hide resolved
4e5159c to
bf9694f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Fixes wordpress-mobile/gutenberg-mobile#5470
Add metadata parameter to the media upload success event that is passed to the Gutenberg editor. This parameter is open to any information around the media that can be useful to have when the upload finishes successfully.
This PR also includes the VideoPress GUID to the metadata parameter as it's needed to render the VideoPress block.
To test
NOTE: This change can only be tested on development using a patch file in Gutenberg.
Regression Notes
Potential unintended areas of impact
This change shouldn't produce any side effects but if any, it would affect the media uploads in the editor.
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested uploads on the different media blocks:
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.