Use the Gutenberg fix for Enter at end of list block #9614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniloercoli
approved these changes
Apr 15, 2019
Contributor
daniloercoli
left a comment
daniloercoli
left a comment
There was a problem hiding this comment.
LGTM! Maybe restart the workflows that are failing? Don't have the permissions to do that.
Contributor
Author
Tried that a few times already to no avail. Still investigating... |
Contributor
Author
|
👋 @marecar3 , I've added you as a reviewer since you might have a chance to do it shortly (timezones FTW :) ). Danilo has already reviewed and accepted the changes for the list block related part. I've added a fix for the JitPack issue (not being able to produce the Android JS bundle) that was blocking the CircleCI build. The gutenberg-mobile side fix is in the wordpress-mobile/gutenberg-mobile#873 PR. |
Contributor
|
Hey @hypest I will take a look at it :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in a newer version of Aztec, to include the fix for the list block writing flow. See the gutenberg-mobile PR for details.
To test:
Update release notes:
RELEASE-NOTES.txt.