Skip to content

Conversation

@hypest
Copy link
Contributor

@hypest hypest commented Apr 13, 2019

Fixes #845

This PR updates to a fixed Aztec Android version. No changes on the gutenberg-mobile side.

Aztec-Android PR: wordpress-mobile/AztecEditor-Android#807
WPAndroid PR: wordpress-mobile/WordPress-Android#9614

To test:

  1. In the demo app, do a long list, long enough to have a few empty list items here and there
  2. Try to add a new item at the end of the list
  3. The new list item should be normally created at the end and the caret should be placed on it

@daniloercoli
Copy link
Contributor

daniloercoli commented Apr 15, 2019

I've tested this PR and it seems to work fine.

The tests I run on this PR was to copy one emoji, that is made up by two characters plus the ZWJ between them, taken from here https://emojipedia.org/emoji-zwj-sequences/ , and pasting it in the editor ---> It worked without problem. Also tried rotating the device, adding and removing the emojis, end other tests.

When trying to paste content to list instead I noticed two problems (Not related to this PR since I was able to replicate them in develop):

  • The option menu doesn't appear
  • Tap long on the caret does make a selection of text (even it there is no visible text on the screen)
    and then option menu appear on the screen.

Video of the problems above: https://cloudup.com/cDVY7Mi5ka0

@hypest
Copy link
Contributor Author

hypest commented Apr 15, 2019

TIL about the use of ZWJs in emojis! 😰

Great idea trying those out @daniloercoli 🙇 and glad they work 🎉 . Looping back, I added info about this in this comment.

When trying to paste content to list instead I noticed two problems

Would you mind opening tickets for those @daniloercoli ?

Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest
Copy link
Contributor Author

hypest commented Apr 15, 2019

This PR works and is green on CI, but the parent wpandroid PR fails because the JS bundling fails on JitPack. That's a problem not related to this PR though so, I'm going to merge and tackle the JitPack issue separately.

@hypest hypest merged commit f767b6f into develop Apr 15, 2019
@hypest hypest deleted the issue/845-android-list-caret-at-end branch April 15, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] List Block's caret positioning is off when new item at the end

3 participants