Skip to content

Conversation

@illusaen
Copy link
Contributor

@illusaen illusaen commented Jan 13, 2021

Description

Added capabilities in order to determine whether contact info should be shown or not.

See further descriptions in linked PRs:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 13, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@jkmassel
Copy link
Contributor

👋 Howdy! We are cutting the 16.6 release today.

Because of that, this PR will be bumped to 16.7. If you need it to be part of 16.6, please merge it into the release/16.6 branch and DM me – I'll be happy to cut a new beta release!

@jkmassel jkmassel modified the milestones: 16.6, 16.7 Jan 25, 2021
@illusaen
Copy link
Contributor Author

See wordpress-mobile/gutenberg-mobile#3064 for issue coming up with contact info block itself.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 3, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jkmassel
Copy link
Contributor

jkmassel commented Feb 8, 2021

👋 We're freezing 16.7 today, so this PR is being bumped to 16.8. If you need this to be part of the 16.7 release, please merge it into the release/16.7 branch and DM me – I'll be happy to cut a new beta release!

@jkmassel jkmassel modified the milestones: 16.7, 16.8 Feb 8, 2021
@illusaen illusaen changed the title Contact Info Enabled in Production Contact Info - Adding Feature Flag + Jetpack API for version check Feb 9, 2021
@illusaen illusaen force-pushed the contact-info-api branch 2 times, most recently from b638436 to 51a9b5c Compare February 9, 2021 21:53
@cameronvoell
Copy link
Contributor

cameronvoell commented Feb 12, 2021

Hey @illusaen I wasn't able to verify the functionality using the WPiOS build from this PR. Digging a little (comment here), I'm guessing maybe this feature is still DEV only so the only way to test is to run while connected to metro bundler locally. Can you confirm?

While testing locally with metro the feature seemed to be working correctly, I just want to ensure that this is what we intended.

@illusaen
Copy link
Contributor Author

Hey @illusaen I wasn't able to verify the functionality using the WPiOS build from this PR. Digging a little (comment here), I'm guessing maybe this feature is still DEV only so the only way to test is to run while connected to metro bundler locally. Can you confirm?

While testing locally with metro the feature seemed to be working correctly, I just want to ensure that this is what we intended.

@cameronvoell Yes that's correct! I haven't removed the DEV flag yet because there's still a keyboard bug that needs to be fixed first.

Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with emulator connected to my local bundler. I confirmed a jurassic ninja site with jetpack enabled showed the contact info block, and no jetpack did not show the block. I also had an old version of jetpack on one site that also correctly did not show the contact info block available. This should be good to go once we update podfile, etc.

@jkmassel
Copy link
Contributor

👋 We're freezing 16.8 today, so this PR is being bumped to 16.9. If you need this to be part of the 16.8 release, please merge it into the release/16.8 branch and DM me – I'll be happy to cut a new beta release!

@jkmassel jkmassel modified the milestones: 16.8, 16.9 Feb 22, 2021
@jkmassel
Copy link
Contributor

jkmassel commented Mar 8, 2021

We've pushed this out from several releases, so I'm moving this to the someday milestone 😃

@jkmassel jkmassel modified the milestones: 16.9, Someday Mar 8, 2021
@illusaen
Copy link
Contributor Author

illusaen commented Mar 8, 2021

We've pushed this out from several releases, so I'm moving this to the someday milestone 😃

Lol yes, been doing my different rotations, sorry!

@illusaen illusaen force-pushed the contact-info-api branch 2 times, most recently from 24df522 to f603e13 Compare March 23, 2021 23:47
@illusaen illusaen merged commit be8a453 into develop Mar 31, 2021
@illusaen illusaen deleted the contact-info-api branch March 31, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants