-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Contact Info - Adding Feature Flag + Jetpack API for version check #15634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
👋 Howdy! We are cutting the Because of that, this PR will be bumped to |
54bb144 to
9d24730
Compare
|
See wordpress-mobile/gutenberg-mobile#3064 for issue coming up with contact info block itself. |
0bf45ff to
80f5050
Compare
80f5050 to
cb51404
Compare
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
👋 We're freezing |
b0ea0b0 to
6cbd1a1
Compare
b638436 to
51a9b5c
Compare
|
Hey @illusaen I wasn't able to verify the functionality using the WPiOS build from this PR. Digging a little (comment here), I'm guessing maybe this feature is still DEV only so the only way to test is to run while connected to metro bundler locally. Can you confirm? While testing locally with metro the feature seemed to be working correctly, I just want to ensure that this is what we intended. |
@cameronvoell Yes that's correct! I haven't removed the DEV flag yet because there's still a keyboard bug that needs to be fixed first. |
cameronvoell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully with emulator connected to my local bundler. I confirmed a jurassic ninja site with jetpack enabled showed the contact info block, and no jetpack did not show the block. I also had an old version of jetpack on one site that also correctly did not show the contact info block available. This should be good to go once we update podfile, etc.
|
👋 We're freezing |
|
We've pushed this out from several releases, so I'm moving this to the |
Lol yes, been doing my different rotations, sorry! |
24df522 to
f603e13
Compare
f603e13 to
fb3cf66
Compare
Description
Added capabilities in order to determine whether contact info should be shown or not.
See further descriptions in linked PRs:
gutenberg-mobile: #3001gutenberg: #28168WPAndroid: #13758PR submission checklist:
RELEASE-NOTES.txtif necessary.