[RNMobile] Added contactInfoBlock enabling capabilities flag to mobile gutenberg bridge #28293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzorz
added
the
Mobile App - i.e. Android or iOS
This was referenced Jan 18, 2021
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
jd-alexander
approved these changes
Jan 27, 2021
Contributor
jd-alexander
left a comment
jd-alexander
left a comment
There was a problem hiding this comment.
The bridge code changes for supporting the ContactInfo Block looks good. I tested these changes with the WP Android PR and the behaviors I observed were as follows
1.When the build config value in the vanilla block was set to true with the Jetpack version at 9.3.1 the Contact Info Block was shown in the inserter.
2. When the build config value in the vanilla block was set to false with Jetpack version 9.3.1 the Contact Info Block was NOT shown.
3. When the build config value was true and the Jetpack version was rolled back to 8.4.2 (below 8.5) the Contact Info block was NOT shown.
LGTM 🚢
Contributor
jd-alexander
left a comment
jd-alexander
left a comment
There was a problem hiding this comment.
I approve of the Android side of things but the WPiOS PR still has to reviewed.
illusaen
approved these changes
Jan 27, 2021
Contributor
illusaen
left a comment
illusaen
left a comment
There was a problem hiding this comment.
Looks good on iOS side!
Closed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added native bridge capabilities for iOS and Android in order to determine whether contact info should be shown or not.
Replaces #28168
See further descriptions in linked PRs:
gutenberg-mobile: #3001 and Contact info api jetpack / update Gutenberg submodule wordpress-mobile/gutenberg-mobile#3015WPiOS: #15634WPAndroid: #13758 and Contact info api - featureConfig implementation wordpress-mobile/WordPress-Android#13804Checklist: