Skip to content

[Gutenberg] Add Cover block media settings #15665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcalhoun merged 20 commits into from
Feb 15, 2021
Merged

[Gutenberg] Add Cover block media settings #15665

dcalhoun merged 20 commits into from
Feb 15, 2021

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 19, 2021 •
edited
Loading

Fixes wordpress-mobile/gutenberg-mobile#1741

To test: Test plan in Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 19, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@dcalhoun dcalhoun mentioned this pull request Jan 19, 2021
Closed
3 tasks
@dcalhoun dcalhoun added the Gutenberg Editing and display of Gutenberg blocks. label Jan 19, 2021
@dcalhoun dcalhoun mentioned this pull request Jan 19, 2021
Merged
2 tasks
@ghost ghost mentioned this pull request Jan 19, 2021
Merged
6 tasks
@dcalhoun dcalhoun mentioned this pull request Jan 19, 2021
Merged
3 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 19, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@dcalhoun dcalhoun force-pushed the gutenberg/media-settings branch from e11cdcc to 451db9e Compare January 19, 2021 21:26
@dcalhoun dcalhoun marked this pull request as ready for review January 19, 2021 23:07
@dcalhoun dcalhoun requested a review from geriux January 19, 2021 23:07
@dcalhoun dcalhoun force-pushed the gutenberg/media-settings branch from dc508c7 to e73e44c Compare January 29, 2021 22:03
@dcalhoun dcalhoun self-assigned this Feb 3, 2021
@dcalhoun dcalhoun force-pushed the gutenberg/media-settings branch from e73e44c to 2fe53d8 Compare February 3, 2021 22:37
@dcalhoun dcalhoun assigned geriux and unassigned dcalhoun Feb 11, 2021
geriux
geriux approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved via WordPress/gutenberg#25810 (review)

@dcalhoun dcalhoun merged commit 8dcf589 into develop Feb 15, 2021
@dcalhoun dcalhoun deleted the gutenberg/media-settings branch February 15, 2021 20:09
@dcalhoun dcalhoun mentioned this pull request Feb 15, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@geriux geriux

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cover block: Add media settings(fixed background and focal point picker)

3 participants

@dcalhoun @geriux