Skip to content

Add Cover block media settings #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcalhoun merged 13 commits into from
Feb 15, 2021
Merged

Add Cover block media settings #3028

dcalhoun merged 13 commits into from
Feb 15, 2021

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jan 19, 2021 •
edited
Loading

Fixes #1741

To test: Test plan in Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun force-pushed the add/cover-block-media-settings branch from 7b212f3 to 08c959a Compare January 19, 2021 17:35
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 19, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ghost ghost mentioned this pull request Jan 19, 2021
Merged
6 tasks
This was referenced Jan 19, 2021
Closed
Merged
Merged
@dcalhoun dcalhoun force-pushed the add/cover-block-media-settings branch from 2533475 to b8d5204 Compare January 19, 2021 22:17
@dcalhoun dcalhoun marked this pull request as ready for review January 19, 2021 23:06
@dcalhoun dcalhoun requested a review from geriux January 19, 2021 23:06
@dcalhoun dcalhoun force-pushed the add/cover-block-media-settings branch from be73ce5 to 10fea9e Compare January 29, 2021 18:10
@dcalhoun dcalhoun self-assigned this Feb 3, 2021
@dcalhoun dcalhoun force-pushed the add/cover-block-media-settings branch from 10fea9e to afa4d71 Compare February 3, 2021 22:07
@dcalhoun dcalhoun force-pushed the add/cover-block-media-settings branch from afa4d71 to 3f37939 Compare February 11, 2021 12:53
@dcalhoun dcalhoun assigned geriux and unassigned dcalhoun Feb 11, 2021
geriux
geriux approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved via WordPress/gutenberg#25810 (review)

@dcalhoun dcalhoun force-pushed the add/cover-block-media-settings branch from 8b81134 to 513b070 Compare February 15, 2021 16:36
@dcalhoun dcalhoun merged commit c51c046 into develop Feb 15, 2021
@dcalhoun dcalhoun deleted the add/cover-block-media-settings branch February 15, 2021 18:17
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@geriux geriux

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cover block: Add media settings(fixed background and focal point picker)

3 participants

@dcalhoun @geriux