Editor - Move Undo/Redo to the header #20930

geriux · 2023-06-21T19:07:03Z

Related PRs:

This PR adds new undo/redo buttons in the navigation bar when the editor is opened, it also updates the existing menu icon.

Screenshots

iPhone Light mode	iPhone Dark mode

iPhone Landscape Light mode	iPhone Landscape Dark mode

iPhone RTL

iPad Light mode	iPad Dark mode

iPad Landscape Light mode	iPad Landscape Dark mode

To test

Install the build
Create a new post
Add a few blocks/text
Tap on the new undo/redo buttons in the navigation bar
Expect the content to change accordingly depending on the button you've tapped

Bonus testing: follow these test cases.

Regression Notes

Potential unintended areas of impact
Post publishing
What I did to test those areas of impact (or what existing automated tests I relied on)
Rely on current tests and manual testing
What automated tests I added (or what prevented me from doing so)
Added new tests for testing the new undo/redo buttons in the navigation bar.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
VoiceOver.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
iPhone and iPad.
Multi-tasking: Split view and Slide over. (iPad)

wpmobilebot · 2023-06-21T19:58:02Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr20930-cd4bc84
	Version	22.8
	Bundle ID	org.wordpress.alpha
	Commit	`cd4bc84`
	App Center Build	WPiOS - One-Offs #6299

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot · 2023-06-21T19:59:36Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr20930-cd4bc84
	Version	22.8
	Bundle ID	com.jetpack.alpha
	Commit	`cd4bc84`
	App Center Build	jetpack-installable-builds #5324

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

tiagomar

Hey @geriux, let me start by saying that I only reviewed the UI Tests related changes, so a review from other engineer is still needed.

I've left a few comments and suggestions, being the one around avoiding duplication, and the naming convention for assertion steps, the ones that require changes. [Don't simply trust the suggestions, I haven't tested them and some do impact others. 😬 ]

Thanks for adding the UI Tests! 🙇‍♂️

WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift

WordPress/UITests/Tests/EditorGutenbergTests.swift

momo-ozawa

Works as described! Left one q

WordPress/Classes/ViewRelated/Post/PostEditorNavigationBarManager.swift

… being disabled

…or both Aztec and Gutenberg, for Gutenberg it will include new undo/redo buttons, for Aztec it will keep the current ones. It also updates the "Generating preview" text that used to be shown in the header title, now it will show in a SVProgressHUD. Removes the reloadBlogTitleView code since it is no longer needed.

momo-ozawa

LGTM!

tiagomar

Thanks for considering the suggestions! 🙇
Everything looks good from a UI Tests perspective.

# Conflicts: # Gutenberg/version.rb # Podfile.lock # WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift

…om the editor design changes

# Conflicts: # Podfile.lock

geriux added [Status] In Progress Gutenberg Editing and display of Gutenberg blocks. labels Jun 21, 2023

This was referenced Jun 22, 2023

Move Undo/Redo buttons wordpress-mobile/gutenberg-mobile#5889

Merged

[Mobile] - Move Undo/Redo buttons WordPress/gutenberg#51766

Merged

Editor - Move Undo/Redo to the header wordpress-mobile/WordPress-Android#18705

Merged

derekblank mentioned this pull request Jun 28, 2023

Update Editor Publish button tint color from editorPrimary to UIColor.black #20951

Closed

13 tasks

Gerardo added 5 commits June 29, 2023 18:25

Editor - Move Undo/Redo to the header

f438e4f

Post Editor - Update Site icon size and spacing between buttons

7795aab

Editor Bar Manager - Add opacity change to custom buttom on pressed

47a6626

Add UI tests for the Undo/Redo functionality

9c8c82c

Update Gutenberg ref

1777067

geriux force-pushed the gutenberg/move-undo-redo-buttons branch from bcc1f6a to 1777067 Compare June 29, 2023 16:31

geriux added this to the 22.8 milestone Jun 29, 2023

Gerardo added 2 commits June 29, 2023 18:45

Remove duplicated UITest button after fixing conflicts

cc6b426

Fix border line for the navigation bar for landscape orientation

9221a3e

geriux force-pushed the gutenberg/move-undo-redo-buttons branch from a0772b4 to 9221a3e Compare June 30, 2023 10:24

Gerardo added 2 commits June 30, 2023 17:46

Fix undo/redo buttons for RTL

fa7e956

Fix test

6f9a0d3

geriux removed the [Status] In Progress label Jul 3, 2023

geriux marked this pull request as ready for review July 3, 2023 14:41

geriux requested a review from a team as a code owner July 3, 2023 14:41

tiagomar suggested changes Jul 4, 2023

View reviewed changes

momo-ozawa reviewed Jul 5, 2023

View reviewed changes

WordPress/Classes/ViewRelated/Post/PostEditorNavigationBarManager.swift Outdated Show resolved Hide resolved

geriux modified the milestones: 22.8, 22.9 Jul 6, 2023

Gerardo added 3 commits July 6, 2023 09:17

BlockEditorScreen - Remove assertion within undo/redo

ce5d637

EditorGutenberg tests - Update naming for asserting undo/redo buttons…

9747901

… being disabled

EditorGutenbergTests - Unify undo/redo tests into one

33717fb

geriux requested review from momo-ozawa and tiagomar July 6, 2023 08:57

momo-ozawa approved these changes Jul 6, 2023

View reviewed changes

tiagomar approved these changes Jul 6, 2023

View reviewed changes

geriux self-assigned this Jul 6, 2023

Gerardo added 8 commits July 7, 2023 18:13

Merge branch 'trunk' into gutenberg/move-undo-redo-buttons

ac921c7

# Conflicts: # Gutenberg/version.rb # Podfile.lock # WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift

Update Gutenberg ref

e83eb6d

Update PostEditorNavigationBar close button margin with new values fr…

e9ca5d7

…om the editor design changes

Update Gutenberg ref

af98f69

Update Gutenberg ref

007ed0e

Merge branch 'trunk' into gutenberg/move-undo-redo-buttons

9a084bb

# Conflicts: # Podfile.lock

Update Podfile.lock

a92218c

Update Release notes

cd4bc84

geriux merged commit 48b8a39 into trunk Jul 11, 2023

geriux deleted the gutenberg/move-undo-redo-buttons branch July 11, 2023 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Editor - Move Undo/Redo to the header #20930

Editor - Move Undo/Redo to the header #20930

Uh oh!

geriux commented Jun 21, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Jun 21, 2023 •

edited

Loading

Uh oh!

wpmobilebot commented Jun 21, 2023 •

edited

Loading

Uh oh!

tiagomar left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

momo-ozawa left a comment

Uh oh!

Uh oh!

momo-ozawa left a comment

Uh oh!

tiagomar left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Editor - Move Undo/Redo to the header #20930

Editor - Move Undo/Redo to the header #20930

Uh oh!

Conversation

geriux commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

To test

Regression Notes

Uh oh!

wpmobilebot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tiagomar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

momo-ozawa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

momo-ozawa left a comment

Choose a reason for hiding this comment

Uh oh!

tiagomar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

geriux commented Jun 21, 2023 •

edited

Loading

wpmobilebot commented Jun 21, 2023 •

edited

Loading

wpmobilebot commented Jun 21, 2023 •

edited

Loading