Skip to content

Editor - Move Undo/Redo to the header #20930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geriux merged 21 commits into from
Jul 11, 2023
Merged

Editor - Move Undo/Redo to the header #20930

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f438e4f
Editor - Move Undo/Redo to the header
Jun 21, 2023
7795aab
Post Editor - Update Site icon size and spacing between buttons
Jun 22, 2023
47a6626
Editor Bar Manager - Add opacity change to custom buttom on pressed
Jun 22, 2023
9c8c82c
Add UI tests for the Undo/Redo functionality
Jun 29, 2023
1777067
Update Gutenberg ref
Jun 29, 2023
cc6b426
Remove duplicated UITest button after fixing conflicts
Jun 29, 2023
9221a3e
Fix border line for the navigation bar for landscape orientation
Jun 30, 2023
fa7e956
Fix undo/redo buttons for RTL
Jun 30, 2023
6f9a0d3
Fix test
Jun 30, 2023
ce5d637
BlockEditorScreen - Remove assertion within undo/redo
Jul 6, 2023
9747901
EditorGutenberg tests - Update naming for asserting undo/redo buttons…
Jul 6, 2023
33717fb
EditorGutenbergTests - Unify undo/redo tests into one
Jul 6, 2023
d22dc57
Update PostEditorNavigationBarManager to have two different buttons f…
Jul 6, 2023
ac921c7
Merge branch 'trunk' into gutenberg/move-undo-redo-buttons
Jul 7, 2023
e83eb6d
Update Gutenberg ref
Jul 7, 2023
e9ca5d7
Update PostEditorNavigationBar close button margin with new values fr…
Jul 10, 2023
af98f69
Update Gutenberg ref
Jul 10, 2023
007ed0e
Update Gutenberg ref
Jul 11, 2023
9a084bb
Merge branch 'trunk' into gutenberg/move-undo-redo-buttons
Jul 11, 2023
a92218c
Update Podfile.lock
Jul 11, 2023
cd4bc84
Update Release notes
Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Editor Bar Manager - Add opacity change to custom buttom on pressed
  • Loading branch information
Gerardo committed Jun 29, 2023
commit 47a6626585c14807dd9218b6f1b5012d7d25074e
10 changes: 9 additions & 1 deletion WordPress/Classes/ViewRelated/Post/PostEditorNavigationBarManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@ protocol PostEditorNavigationBarManagerDelegate: AnyObject {
class ExtendedTouchAreaButton: UIButton {
private var touchAreaPadding: CGFloat = 24.0

override var isHighlighted: Bool {
didSet {
UIView.animate(withDuration: 0.2) {
self.alpha = self.isHighlighted ? 0.5 : 1.0
}
}
}

override func point(inside point: CGPoint, with event: UIEvent?) -> Bool {
let extendedArea = bounds.insetBy(dx: -touchAreaPadding, dy: -touchAreaPadding)
return extendedArea.contains(point)
Expand Down Expand Up @@ -59,7 +67,7 @@ class PostEditorNavigationBarManager {
}()

lazy var closeButtonContainer: ExtendedTouchAreaButton = {
let button = ExtendedTouchAreaButton(type: .system)
let button = ExtendedTouchAreaButton(type: .custom)
button.translatesAutoresizingMaskIntoConstraints = false
button.accessibilityIdentifier = "editor-close-button"
button.accessibilityLabel = NSLocalizedString("Close", comment: "Action button to close the editor")
Expand Down