Skip to content

Conversation

@ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Apr 26, 2018

Fixes #9213

NOTES:

  • Your local .wpcom_app_credentials must be up-to-date as it contains Zendesk credentials. If you have not, refer to the Field Guide for instructions.
  • SupportSourceTag.inAppFeedback is not passed on to Zendesk. This will be addressed with a future task that implements SourceTag support.

To test:

  • Since displaying the App Feedback view is dependent on many conditions, it probably won't just appear. My suggested hack - in NotificationsViewController:showRatingViewIfApplicable comment out the first guard that checks shouldPromptForAppReview. The App Feedback view will always show, but at least you'll see it!
  • Go to the Notifications tab.
  • Select 'Could Be Better'.
  • Select 'Send Feedback'.
  • Verify the Zendesk ticket view is displayed.

Zendesk View (you should see this):
zendesk_view

Helpshift View (you should not see this):
helpshift_view

@etoledom - can I bother you for a review please? Thank you!!

@ScoutHarris ScoutHarris added this to the 10.0 milestone Apr 26, 2018
@ScoutHarris ScoutHarris self-assigned this Apr 26, 2018
@ScoutHarris ScoutHarris requested a review from etoledom April 26, 2018 22:02
@ScoutHarris ScoutHarris changed the base branch from feature/9170-jetpack_selfhosted_zendesk_support to develop April 26, 2018 22:09
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ScoutHarris !
The code looks good and it works perfectly as advised 🎉
Let's :shipit:

@etoledom
Copy link
Contributor

etoledom commented Apr 26, 2018

Thanks for the hack tip again. 😁

@ScoutHarris ScoutHarris merged commit dfd230a into develop Apr 26, 2018
@ScoutHarris ScoutHarris deleted the feature/9213-app_feedback_show_zendesk branch April 26, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants