Skip to content

Zendesk Mobile: show Zendesk new ticket from App Ratings > Send Feedback. #9214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScoutHarris merged 3 commits into from
Apr 26, 2018
Merged

Zendesk Mobile: show Zendesk new ticket from App Ratings > Send Feedback. #9214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87b26dd
Let `ZendeskUtils` call `createRequest` since it will always be neede…
ScoutHarris Apr 26, 2018
8ca0e96
Show Zendesk new ticket view from App Feedback.
ScoutHarris Apr 26, 2018
0a7d853
Merge branch 'develop' into feature/9213-app_feedback_show_zendesk
ScoutHarris Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions WordPress/Classes/Utility/ZendeskUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ import CoreTelephony

let presentInController = ZendeskUtils.configureViewController(controller)
ZDKRequests.presentRequestCreation(with: presentInController)
createRequest()
}

func showTicketList(from controller: UIViewController) {
Expand Down
27 changes: 19 additions & 8 deletions WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,15 +1401,26 @@ extension NotificationsViewController: AppFeedbackPromptViewDelegate {
WPAnalytics.track(.appReviewsOpenedFeedbackScreen)
AppRatingUtility.shared.gaveFeedbackForCurrentVersion()
hideRatingViewWithDelay(0.0)
if HelpshiftUtils.isHelpshiftEnabled() {
let presenter = HelpshiftPresenter.init()
presenter.sourceTag = SupportSourceTag.inAppFeedback
presenter.presentHelpshiftConversationWindowFromViewController(self,
refreshUserDetails: true,
completion: nil)

if FeatureFlag.zendeskMobile.enabled {
if ZendeskUtils.sharedInstance.zendeskEnabled {
ZendeskUtils.sharedInstance.showNewRequest(from: self)
} else {
if let contact = URL(string: NotificationsViewController.contactURL) {
UIApplication.shared.open(contact)
}
}
} else {
if let contact = URL(string: NotificationsViewController.contactURL) {
UIApplication.shared.open(contact)
if HelpshiftUtils.isHelpshiftEnabled() {
let presenter = HelpshiftPresenter.init()
presenter.sourceTag = SupportSourceTag.inAppFeedback
presenter.presentHelpshiftConversationWindowFromViewController(self,
refreshUserDetails: true,
completion: nil)
} else {
if let contact = URL(string: NotificationsViewController.contactURL) {
UIApplication.shared.open(contact)
}
}
}
}
Expand Down
3 changes: 0 additions & 3 deletions WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,10 @@ private extension SupportTableViewController {
return { [unowned self] row in
self.tableView.deselectSelectedRowWithAnimation(true)
if ZendeskUtils.sharedInstance.zendeskEnabled {

guard let controllerToShowFrom = self.controllerToShowFrom() else {
return
}

ZendeskUtils.sharedInstance.showNewRequest(from: controllerToShowFrom)
ZendeskUtils.sharedInstance.createRequest()
} else {
guard let url = Constants.forumsURL else {
return
Expand Down