Skip to content

Conversation

@mzorz
Copy link
Contributor

@mzorz mzorz commented Aug 14, 2018

This fixes the problem with keeping up with focused state as described in #88 (comment).
Fixed by @hypest, copying here the description of what this does:

I think that happens there is that onChange breaks the “contract” where the block instances in the DataSource need to be the very same ones as in the props

This diff effectively makes sure to use the same block instance and update the instance attributes, then sending the updated changes to the redux store.

props to @hypest once more.

@mzorz mzorz requested a review from hypest August 14, 2018 12:33
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants