Skip to content

Feature: Inserter - 1st iteration with Picker #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mzorz merged 58 commits into from
Aug 17, 2018
Merged

Feature: Inserter - 1st iteration with Picker #123

mzorz merged 58 commits into from
Aug 17, 2018

Conversation

@mzorz
Copy link
Contributor

@mzorz mzorz commented Aug 16, 2018

This is the feature PR for 1st iteration of the Inserter.

All of these PRs were already tested and merged in this branch:
#88, #89, #95 #108, #96 #110, and #105

Will continue with next iteration as described in #58 (comment)

mzorz and others added 30 commits July 27, 2018 18:17
@mzorz
added createBlockAction and CREATE action type
fd47cc0
@mzorz
updated dispatcher mapping for createBlockAction
35d3e1c
@mzorz
added reducer for ActionTypes.BLOCK.CREATE actionType
109e3be
@mzorz
changed copypaste wording
f98d844
@mzorz
added ToolbarButton.PLUS button handler inserting new object in List …
6fcd938 
…dataSource
@mzorz
extracted block placeholder creation to buildEmptyBlock function
00aa9d3
@mzorz
moved emptyBlock helper function to block-builder within /store
09102c1
@mzorz
Merge branch 'master' into try/inserter-take1
51981d0
@mzorz
removed debugger statements
de92b5e
@mzorz
using ints for new block ids
abd68f4
@mzorz
modified comment
82c3e7f
@mzorz
fixed createBlock action to correctly propagate the change
2beaebd
@mzorz
updated test
c6ad773
@mzorz
removed logger call
c95ea0b
@mzorz
fix importing type as a value
2abdc07
@mzorz
modified signature of createBlockAction( newId, newBlock ) and fixed …
7dc1b42 
…Flow errors
@mzorz
fixed flow and lint errors
f4d6e85
@mzorz
fixed test for block creation
728ef6a
@mzorz
ditch mocked block-builder in favor of using the actual GB createBloc…
57698ed 
…k interface
@mzorz
fixed tests
4dec244
@mzorz
removed comment
bf1dd7f
@daniloercoli
Merge pull request #89 from wordpress-mobile/try/inserter-use-create-…
5e392d5 
…block-gb

Inserter - use GB createBlock to generate new blocks
@mzorz
Merge branch 'master' into try/inserter-take1
851d191
@mzorz
using new supported core/paragraph block in inserter, and adding focu…
d2d5247 
…sed: false prop in new object
@mzorz
added missing semicolon
f34612b
@mzorz
updated gutenberg repo to latest master
811bd42
@mzorz
Merge branch 'feature/inserter' into try/inserter-take1
303f74f
@mzorz
udpated to latest feature base branch
6abc253
@mzorz
upated to latest master
6ba0a1c
@mzorz
cascading latest changes from master
c3e8f11
mzorz and others added 24 commits August 10, 2018 16:16
@mzorz
added block check in test
e556378
@mzorz
tests: moved registerCoreBlock() to beforeAll()
a04c5e9
@mzorz
removed unused imports
54220f8
@mzorz
Merge pull request #88 from wordpress-mobile/try/inserter-take1
901e5f0 
Inserter - basic support for block addition
@mzorz
fix focus handling - awesomely spotted by @hypest
10e7edd
@mzorz
using index const
3868275
@mzorz
Merge branch 'master' into feature/inserter
7524346
@mzorz
Merge pull request #108 from wordpress-mobile/fix/inserter-focus-hand…
ab0c132 
…ling

Inserter - fix focus handling, awesomely spotted by @hypest
@mzorz
added direct insertion to block manager
401ea8e
@mzorz
making sure to have the RecyclerView update and re-draw the elements …
856533e 
…in viewport when onChange
@mzorz
changed createBlockAction to have the same argument ordering as per i…
728e63a 
…ts BlockActionType
@mzorz
inserter: added RN Picker component to choose from registered block t…
b7c557c 
…ypes when inserting new block
@mzorz
removed unneeded creation of intermediate block object
39f6500
@mzorz
augmented test to also test for clientIdAbove param
8814dc0
@mzorz
removed dupe line
c1b51b9
@mzorz
removed unneeded index/array limit guard'
145e82f
@mzorz
Merge pull request #111 from wordpress-mobile/fix/block-height-not-re…
7b7429b 
…freshed

Inserter - have the RecyclerView update and re-draw item in onChange
@mzorz
differentiating a CreateActionType
dbdfaff
@mzorz
fixed lint warnings
d0baa01
@mzorz
Merge pull request #110 from wordpress-mobile/try/inserter-take1-stat…
deb3ef5 
…e-props-direct-insert-take2

Inserter - added direct insertion to block manager (take2)
@mzorz
cascading merge from feature branch - updated guteberg hash
656819f
@mzorz
Merge branch 'feature/inserter' into try/inserter-take1-state-props-s…
017a8cc 
…how-reg-blocks-take2
@koke
Merge pull request #112 from wordpress-mobile/try/inserter-take1-stat…
57650c6 
…e-props-show-reg-blocks-take2

Inserter - show Picker with registered blocks to choose from
@mzorz
fixed merge conflicts with master
f708c5d
@mzorz mzorz requested a review from hypest August 16, 2018 18:28
hypest
hypest approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mzorz mzorz merged commit 46ac1d0 into master Aug 17, 2018
@mzorz mzorz deleted the feature/inserter branch August 17, 2018 17:02
@mzorz mzorz mentioned this pull request Aug 18, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hypest hypest hypest approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mzorz @hypest @daniloercoli @koke