Skip to content

Update aztec to 1.15.0 #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergioEstevao merged 5 commits into from
Jan 21, 2020
Merged

Update aztec to 1.15.0 #1775

SergioEstevao merged 5 commits into from
Jan 21, 2020

Conversation

@SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jan 14, 2020 •
edited
Loading

This PR updates Aztec version to 1.15.0

WP-iOS PR: wordpress-mobile/WordPress-iOS#13228

Fixes #

To test:

  • Smoke test the demo app to see if all is good
  • Do an extra check on the header block and blockquote block because of changes made in Aztec to that code.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label Jan 14, 2020
@SergioEstevao SergioEstevao added this to the 1.21 milestone Jan 14, 2020
etoledom
etoledom approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! 🎉

Let's target the release branch before merging: #1788

ios/gutenberg.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
Comment on lines +1 to +8
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>IDEDidComputeMac32BitWarning</key>
<true/>
</dict>
</plist>
Copy link
Contributor

@etoledom etoledom Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. But it looks harmless

@SergioEstevao SergioEstevao changed the base branch from develop to release/1.21.0 January 21, 2020 11:54
@SergioEstevao SergioEstevao merged commit 85d1141 into release/1.21.0 Jan 21, 2020
@SergioEstevao SergioEstevao deleted the issue/update_aztec_to_1_15.0 branch January 21, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

1.21

Development

Successfully merging this pull request may close these issues.

3 participants

@SergioEstevao @etoledom