Skip to content

Conversation

@etoledom
Copy link
Contributor

@etoledom etoledom commented Jan 20, 2020

Release for Gutenberg Mobile v1.21.0

Related PRs

Changes

Test plan

  • Use the main WP apps to test the changes above. See WPAndroid and WPiOS PRs if there are specific tests to run.
  • Smoke test the main WP apps for general writing flow.

SergioEstevao and others added 4 commits January 21, 2020 11:45
react-native-aztec

This is a temporary fix to get the Jitpack builds back to green while I
work on a solution that doesn't use hardcoded values.
xcworkspace dir makes UITests to fail.
@etoledom etoledom marked this pull request as ready for review January 21, 2020 18:05
@@ -1,9 +1,15 @@
1.21.0
------
* [Android] Reduced padding around text on Rich Text based blocks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an Android specific fix. But there was also a general change that reduced padding around text on Rich Text based blocks.

@etoledom etoledom requested a review from maxme January 23, 2020 22:36
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@etoledom
Copy link
Contributor Author

Force merging since the failing test is a known flaky test on "Test Android on Device"

Thanks @maxme for the review and release notes update! And @mchowning for the ✅ 🙏

@etoledom etoledom merged commit beff3d2 into master Jan 23, 2020
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hypest hypest deleted the release/1.21.0 branch January 24, 2020 13:48
@designsimply
Copy link
Contributor

Thank you for including PR links in the Changes section! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.