Slot/Fill pattern with Toolbar #199
Conversation
|
Update: Currently I am fixing the tests. |
koke
left a comment
koke
left a comment
There was a problem hiding this comment.
Spotted a small typo, and really wanted to try GitHub's new suggest code feature 😁
| this.props.focusBlockAction( clientId ); | ||
| } | ||
|
|
||
| focusDataSoruceItem(clientId: string) { |
There was a problem hiding this comment.
| focusDataSoruceItem(clientId: string) { | |
| focusDataSourceItem(clientId: string) { |
| } | ||
|
|
||
| onBlockHolderPressed( clientId: string ) { | ||
| this.focusDataSoruceItem(clientId); |
There was a problem hiding this comment.
| this.focusDataSoruceItem(clientId); | |
| this.focusDataSourceItem(clientId); |
If you have your |
|
Nice work @marecar3 ! Tried the PR locally and it seems something goes wrong with the number by the heading buttons (check out the "2", the "3" and the "4" in the Android screenshot below):
|
marecar3
changed the title
|
You will have to wrap every block with |
|
|
||
| return ( | ||
| <Block | ||
| <BlockEdit |
There was a problem hiding this comment.
Check also https://github.com/WordPress/gutenberg/blob/master/packages/editor/src/components/block-list/block.js#L451-L462 for reference. It seems to look good at first glance.
# Conflicts: # gutenberg
# Conflicts: # gutenberg
|
@marecar3 - I'm removing my assignment for the time being (for transparency) as I won't be able to focus on this PR for at least a few days. Sorry! |
|
Hey @diegoreymendez , np, thanks for the update! |
# Conflicts: # gutenberg
koke
left a comment
koke
left a comment
There was a problem hiding this comment.
I approved the Gutenberg PR, so this is good to go after that one is merged and the tests are fixed
…g-mobile into fix/block-mergin-remove-red-screen * 'master' of https://github.com/wordpress-mobile/gutenberg-mobile: Slot/Fill pattern with Toolbar (#199) # Conflicts: # gutenberg
…g-mobile into fix/167-merge-block-loosing-content * 'master' of https://github.com/wordpress-mobile/gutenberg-mobile: Slot/Fill pattern with Toolbar (#199) # Conflicts: # gutenberg # yarn.lock
Description
This PR resolves part of the Toolbar issue. It adds support for Slot/Fill pattern with Toolbar which results in porting list item Toolbar on the bottom of the screen (or on top of the keyboard).
Slot/Fill pattern with Toolbar
What's done :
Context (Consumer, Provider) pattern with Toolbar
How has this been tested?
It is tested against this PR