-
Notifications
You must be signed in to change notification settings - Fork 57
Slot/Fill pattern with Toolbar #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
4c32806
Fix : is block focused logic on Android platform
5e5fafb
Implement Slot/Fill "portal" pattern in gutenberg mobile
defae89
Merge branch 'master' into feature/toolbar_component
1b9e13b
Create block toolbar
marecar3 5893bd0
Merge branch 'master' into feature/toolbar_component
marecar3 b57680f
Renamed Toolbar to InlineToolbar as we want to avoid confusion about …
marecar3 20c9196
Small fixes
marecar3 4a06731
Fixed linter errors
marecar3 86b3334
Fixed typo
marecar3 4eb2387
Build against gutenberg branch
marecar3 7d8b433
Use BlockEdit so that we can propagate isSelected
marecar3 d185c2d
Merge
marecar3 750a430
Update gutenberg submodule
marecar3 31ff3e0
Fix lint error
marecar3 d3c24ea
Merge branch 'master' into feature/toolbar_component
marecar3 79282fc
Update gutenberg submodule
marecar3 20e2dd5
Merge branch 'master' into feature/toolbar_component
marecar3 8a23f20
Updated gutenberg submodule
marecar3 be2efca
Updated gutenberg submodule
marecar3 e8db9c4
Updated gutenberg submodule
marecar3 ec60322
Merge branch 'master' into feature/toolbar_component
marecar3 3ff8de2
Removed unused method
marecar3 63c9ea5
Fixed tests
marecar3 b9af427
Small fix
marecar3 03257ad
Updated gutenberg submodule
marecar3 9f0d684
Fixed lint
marecar3 38d23ba
Updated gutenberg submodule
marecar3 e78187b
Updated gutenberg submodule
marecar3 659a04f
Merge branch 'master' into feature/toolbar_component
marecar3 10944ce
Updated gutenberg submodule
marecar3 f476382
Updated gutenberg submodule
marecar3 f015d48
Updated gutenberg submodule
marecar3 b3f443d
Merge branch 'master' into feature/toolbar_component
marecar3 95af1b7
Updated gutenberg submodule
marecar3 29faa67
Move keyboard to the bottom the screen
marecar3 c9861d9
Add mocked style to fix tests
marecar3 8429f0a
Fixed lint errors on style mock
marecar3 967d5db
Merge branch 'master' into feature/toolbar_component
marecar3 ab00094
Update gutenberg submodule
marecar3 e2ad784
Update gutenberg submodule
marecar3 525ab6c
Fix for package.json to avoid failing builds
marecar3 1051576
Update gutenberg submodule
marecar3 c972b6a
Add symlinked package @wordpress/date
daniloercoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,10 @@ | ||
| /** @flow | ||
| * @format */ | ||
|
|
||
| module.exports = {}; | ||
| module.exports = { | ||
|
|
||
| //Mock block paragraph style with minimum height | ||
| blockText: { | ||
| minHeight: 50, | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import React, { Component } from 'react'; | ||
| import { View } from 'react-native'; | ||
| import { BlockFormatControls, BlockControls } from '@wordpress/editor'; | ||
|
|
||
| export default class BlockToolbar extends Component { | ||
| render() { | ||
| return ( | ||
| <View style={ { height: 50, backgroundColor: '#DCDCDC', flexDirection: 'row' } }> | ||
| <BlockControls.Slot /> | ||
| <BlockFormatControls.Slot /> | ||
| </View> | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
src/block-management/toolbar.scss → src/block-management/inline-toolbar.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../../packages/date/build/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../gutenberg/packages/date/src/ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check also https://github.com/WordPress/gutenberg/blob/master/packages/editor/src/components/block-list/block.js#L451-L462 for reference. It seems to look good at first glance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gziolo !