Skip to content

Fix Web related breakage for using block wrappers #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergioEstevao merged 2 commits into from
Mar 11, 2020
Merged

Fix Web related breakage for using block wrappers #1994

SergioEstevao merged 2 commits into from
Mar 11, 2020

Conversation

@SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Mar 10, 2020 •
edited
Loading

This PR's updates the GB reference to latest Master and brings fix that corrects the web breakage for blocks that use a block wrapper.

Gutenberg PR: WordPress/gutenberg#20772

To test:

  • Run the demo app
  • Check that no errors show up (red-screens) on start.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the Web breakage Caused by incompatible changes on Gutenberg web label Mar 10, 2020
@SergioEstevao SergioEstevao added this to the 1.24 milestone Mar 10, 2020
@SergioEstevao SergioEstevao requested a review from Tug March 10, 2020 15:48
@SergioEstevao SergioEstevao changed the title Update GB reference. Fix Web related breakage for using block wrappers Mar 10, 2020
@SergioEstevao SergioEstevao mentioned this pull request Mar 10, 2020
Merged
6 tasks
Tug
Tug approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@Tug Tug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SergioEstevao SergioEstevao merged commit 29f3753 into develop Mar 11, 2020
@SergioEstevao SergioEstevao deleted the issue/fix_master_breakage branch March 11, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Tug Tug Tug approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Web breakage Caused by incompatible changes on Gutenberg web

Projects

None yet

Milestone

1.24

Development

Successfully merging this pull request may close these issues.

3 participants

@SergioEstevao @Tug