Correct android font weight #2141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with no effect on Android when
fontWeightvalue is numerical.More about the issue you can read here
Going through the comments and potential solutions I've created a function for mapping a font to font-weight called
correctTextFontWeightwhich has to be called from the application starting point (_src/index.js_)To test:
To test:
To test:
NOTE: I would like to add some unit test if you like that approach.
PR submission checklist:
RELEASE-NOTES.txtif necessary.