Remove unneeded fix for text font-weight style #5967
Merged
+0
−76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an unneeded workaround on Android related to correcting the
font-weightstyle when using numerical values. This is no longer needed as a fix was introduced in React Native 0.65 (reference - Fix font weight numeric values).As a side note, I debugged the workaround and noticed that it wasn't actually being applied 😅. The
styleprop is being fetched from the wrong object, as the following code is always returningundefined:gutenberg-mobile/src/text-font-weight-correct.js
Line 55 in 0130fbb
As an example, here the props of
baseTextfor an element that has thefont-weightstyle attribute set:The styles should be fetched from the children element not
baseText. I updated the code to enable the workaround but still the original font-weight issue is no longer happening.To test:
Following the test cases from the PR that introduced the workaround:
PR submission checklist: