Skip to content

Enable default keyboard as default on link picker text fields #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chipsnyder merged 4 commits into from
Feb 18, 2021
Merged

Enable default keyboard as default on link picker text fields #3170

chipsnyder merged 4 commits into from
Feb 18, 2021

Conversation

@chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Feb 17, 2021 •
edited
Loading

Fixes #2733
Gutenberg PR: WordPress/gutenberg#29087

To test:

  1. Add Buttons block or Image Block
  2. Open link settings
  3. Edit the URL field and add a link
  4. Switch on Open in new tab
  5. Edit Link Rel field
  6. Type space to add a new link rel
  7. Expect To see the default keyboard

Screenshots

Before After

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added the [Type] Bug Something isn't working label Feb 17, 2021
@chipsnyder chipsnyder requested review from geriux and mkevins February 17, 2021 19:19
@chipsnyder chipsnyder mentioned this pull request Feb 17, 2021
Merged
7 tasks
@chipsnyder chipsnyder linked an issue Feb 17, 2021 that may be closed by this pull request
[iOS] Can't add new Link Rel to Button because of wrong keyboard type #2733
Closed
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 17, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

geriux
geriux approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#29087 (review)

@geriux
Copy link
Contributor

geriux commented Feb 18, 2021

FYI there's a package-lock.json update in the PR. Was it intentional?

@chipsnyder
Copy link
Contributor Author

chipsnyder commented Feb 18, 2021

FYI there's a package-lock.json update in the PR. Was it intentional?

Yeah, the Check Correctness step kept failing with

Message: package-lock.json has changed. Please run npm install and commit the diff

It's been 3 months 😬 since I made a change in this repo though so I just listened to the bots 🤖 😄

@chipsnyder
Copy link
Contributor Author

chipsnyder commented Feb 18, 2021

I reverted it now and it's happy again so 🤷‍♂️

@geriux
Copy link
Contributor

geriux commented Feb 18, 2021

I reverted it now and it's happy again so 🤷‍♂️

Magic! ✨

@chipsnyder chipsnyder merged commit 3965e70 into develop Feb 18, 2021
@chipsnyder chipsnyder deleted the rnmobile/issue/2733-buttonLinks branch February 18, 2021 14:39
@enejb enejb mentioned this pull request Mar 1, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkevins mkevins Awaiting requested review from mkevins

1 more reviewer

@geriux geriux geriux approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[iOS] Can't add new Link Rel to Button because of wrong keyboard type

3 participants

@chipsnyder @geriux