Skip to content

[RNMobile] Add "Set as Featured Image" Button to Image Block (iOS Only) #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SiobhyB merged 20 commits into from
Jun 25, 2021
Merged

[RNMobile] Add "Set as Featured Image" Button to Image Block (iOS Only) #3450

SiobhyB merged 20 commits into from
Jun 25, 2021

Conversation

@SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented May 3, 2021 •
edited
Loading

Paritial fix for: #1011

gutenberg: WordPress/gutenberg#31415
WordPress-iOS: wordpress-mobile/WordPress-iOS#16426

The main PR for the branch this individual PR will be merged into, add/featured-functionality-to-image-block-ios, can be found here: #3449

Description

This PR will add a Set as Featured button to the image block's settings on iOS devices, with the purpose being to make it simpler for users to set a featured image within the post's editor. Users will also be able to Remove as Featured directly from the block's setting.

Testing

Main Test Flows

The Gutenberg PR can be referred to as the central, most up-to-date repository for the main test flows.

Tracks Verification

The iOS PR can be referred to for steps to verify that the Tracks events edited/introduced with this PR work as expected.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB changed the base branch from develop to add/featured-functionality-to-image-block-ios May 3, 2021 11:58
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 3, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB mentioned this pull request May 3, 2021
Merged
7 tasks
This was referenced May 3, 2021
Merged
Merged
Merged
@SiobhyB SiobhyB force-pushed the add/set-as-featured-button-ios branch from 6c0f9fe to f8b26d9 Compare May 5, 2021 12:09
@SiobhyB SiobhyB added [Status] In Progress [Type] Enhancement Improves a current area of the editor labels May 6, 2021
@SiobhyB SiobhyB mentioned this pull request May 6, 2021
Merged
4 tasks
@SiobhyB SiobhyB self-assigned this May 6, 2021
@SiobhyB SiobhyB force-pushed the add/set-as-featured-button-ios branch from 5e2bc9c to 8bef375 Compare May 13, 2021 13:42
@SiobhyB SiobhyB force-pushed the add/set-as-featured-button-ios branch from 02ed40f to b0b46b7 Compare May 13, 2021 13:45
@SiobhyB SiobhyB force-pushed the add/set-as-featured-button-ios branch 2 times, most recently from de73bcd to 3cfef62 Compare May 27, 2021 10:19
@SiobhyB SiobhyB force-pushed the add/set-as-featured-button-ios branch 2 times, most recently from e9bfbb7 to 6f4644e Compare May 30, 2021 19:40
@SiobhyB SiobhyB force-pushed the add/set-as-featured-button-ios branch from ca6510c to 7dde1e9 Compare May 30, 2021 19:45
@SiobhyB SiobhyB requested a review from guarani June 1, 2021 08:44
guarani
guarani reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a review here: WordPress/gutenberg#31415 (comment)
I think the bundle changes here (specifically the changes to localized strings) might be fixed when #3565, but not sure.

@SiobhyB SiobhyB force-pushed the add/set-as-featured-button-ios branch from a1f5eaa to 222548d Compare June 2, 2021 20:13
@SiobhyB SiobhyB marked this pull request as ready for review June 3, 2021 17:43
@guarani
Copy link
Contributor

guarani commented Jun 4, 2021

Regarding the changes in translation files seen in the diff here, I wonder if #3565 fixed it and this PR just needs to be updated with the latest from develop.

@guarani
Copy link
Contributor

guarani commented Jun 4, 2021 •
edited
Loading

Just want to double-check, after bumping the Gutenberg ref, were the bundles updated as well or was that not required? I always run npm run bundle when bumping the submodule ref, just to be sure.

@SiobhyB SiobhyB force-pushed the add/set-as-featured-button-ios branch from 83696b3 to c13c348 Compare June 4, 2021 12:33
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jun 4, 2021 •
edited
Loading

Regarding the changes in translation files seen in the diff here, I wonder if #3565 fixed it and this PR just needs to be updated with the latest from develop.

I've updated from develop (via the feature branch) now and all looks to be resolved! :)

Just want to double-check, after bumping the Gutenberg ref, were the bundles updated as well or was that not required? I always run npm run bundle when bumping the submodule ref, just to be sure.

I didn't update the bundles, but will do in the future just to be sure. thanks for the heads up on that workflow habit.

@guarani guarani self-requested a review June 24, 2021 21:53
guarani
guarani approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#31415 (review)

@SiobhyB SiobhyB merged commit 7ea2fee into add/featured-functionality-to-image-block-ios Jun 25, 2021
@SiobhyB SiobhyB deleted the add/set-as-featured-button-ios branch June 25, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@guarani guarani guarani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SiobhyB SiobhyB

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SiobhyB @guarani