Pass the Gallery v2 Flag over from the editor #3793
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2021
antonis
added
[OS] Android
[Type] Enhancement
antonis
force-pushed
the
refactor/gallery-as-nested-image-blocks-editor-settings_v2_android
branch
from
d90e217 to
a7f59c4
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
mkevins
approved these changes
Sep 2, 2021
Contributor
mkevins
left a comment
mkevins
left a comment
There was a problem hiding this comment.
Tested via: wordpress-mobile/WordPress-Android#15134 (review)
Thanks Antonis! LGTM!
Just need to update the reference to resolve conflicts.
Author
|
Closing this PR in favour of the iOS PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
WordPress-Android: wordpress-mobile/WordPress-Android#15129WordPress-FluxC-Android: wordpress-mobile/WordPress-FluxC-Android#2065gutenberg: WordPress/gutenberg#33544Description
This PR adds the Gallery v2 Flag to the EditorTheme to be passed down to the Editor
To test:
Check WordPress/gutenberg#33544
PR submission checklist: