RichText - Fix issue with font sizes with decimal values #4324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Contributor
|
👋 Hi @geriux. We will cut the 1.68.0 release on Dec 9th. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.68.0. 🙇 |
Contributor
Author
Hey there @guarani 👋 Yes, I'd like this PR to be included, I'm working on merging it now 😃 |
added 2 commits
December 9, 2021 11:30
# Conflicts: # gutenberg
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
antonis
approved these changes
Dec 9, 2021
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
The reference change LGTM 🎉
Thank you 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where some block-based themes that have font-size values with decimals like
1.125remwould crash the editor.To test check the Gutenberg PR description.
PR submission checklist: