Skip to content

Release 1.68.0 #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guarani merged 58 commits into from
Dec 9, 2021
Merged

Release 1.68.0 #4362

guarani merged 58 commits into from
Dec 9, 2021

Conversation

@guarani
Copy link
Contributor

@guarani guarani commented Dec 9, 2021 •
edited
Loading

Release for Gutenberg Mobile 1.68.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

Change 2

Change 3

Change 4

Change 5

Change 6

Change 7

Change 8

Change 9

Test plan

Once the installable builds are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

fluiddot and others added 30 commits November 25, 2021 13:08
@fluiddot
Update Gutenberg ref
069ebe3
@fluiddot
Update release notes
7583544
@fluiddot
Update Gutenberg ref with merge commit
c0d3deb
@fluiddot
Merge pull request #4290 from wordpress-mobile/fix/undo-redo-link-styles
595ffbc 
Fix undo/redo functionality in links when applying text format [Android]
Update Gutenberg ref
c48d6e3
@SiobhyB
Update reference to Gutenberg
233f21f
@SiobhyB
Merge branch 'develop' into merge_release_1.67.0_to_develop
4a9ee4b
@SiobhyB
Move unreleased change in RELEASE-NOTES
7d10569
@SiobhyB
Merge pull request #4296 from wordpress-mobile/merge_release_1.67.0_t…
caf4aaa 
…o_develop

Merge release 1.67.0 to develop
@fluiddot
Update Gutenberg ref
6eacf2c
@fluiddot
Update Gutenberg ref
f82b311
@fluiddot
Update release notes
4fed1b2
@fluiddot
Update Gutenberg ref with merge commit
2652461
@fluiddot
Merge pull request #4299 from wordpress-mobile/fix/update-scroll-by-c…
f24b86b 
…aret-position

[iOS] Fix scroll update when typing in RichText component
Merge branch 'develop' into fix/preformatted-background-styles
8d78737 
# Conflicts:
#	gutenberg
Update Gutenberg ref
5310e6c
Update Release notes
6e4c71d
Merge pull request #4292 from wordpress-mobile/fix/preformatted-backg…
2fe8987 
…round-styles

Preformatted block - Fix showing the default background color
@mkevins
Update gutenberg reference
d0a4231
@mkevins
Update gutenberg reference
9e6df37
@mkevins
Add release note
2e495c3
@mkevins
Merge pull request #4315 from wordpress-mobile/update/gallery-block-d…
ecafd7d 
…isable-v2-when-useBalanceTags-set

Gallery block: turn on auto-migration of v1 Gallery blocks to v2 format when edited
@fluiddot
Use WP-cli nightly version
c63218a
@fluiddot
Update localization strings files
e4b9c9e
@fluiddot
Update i18n-cache translation files
a46bec8
@fluiddot
Fix make-pot commands
78f5f61
@fluiddot
Update Gutenberg ref
4c2408f
@fluiddot
Update bundle
90a84a6
Update Gutenberg ref
49ee51f
@fluiddot
Force updating the i18n cache files when bundling
cdb695c 
As part of the bundling process, we should re-download and update the i18n cache files to provide the most recent translations.
This was referenced Dec 9, 2021
Merged
Merged
Merged
@guarani
Copy link
Contributor Author

guarani commented Dec 9, 2021

I verified the string changes in the bundle/android/strings.xml and bundle/ios/GutenbergNativeTranslations.swift files by ensuring they are the exact same changes from #4323.
Given that the changes are exactly the same ones seen in that PR, and @fluiddot accounted for each one (thanks Carlos, that was super helpful!) I'm confident these changes are OK and we can proceed with the release.

@guarani guarani requested a review from twstokes December 9, 2021 21:16
@guarani guarani marked this pull request as ready for review December 9, 2021 21:16
twstokes
twstokes approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @guarani 👍

@guarani guarani merged commit b3e9d75 into trunk Dec 9, 2021
@guarani guarani deleted the release/1.68.0 branch December 9, 2021 23:40
@guarani
Copy link
Contributor Author

guarani commented Dec 14, 2021 •
edited
Loading

WPiOS 18.9.0.0 – Writing flow tests

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

Checklist taken from here.

@guarani
Copy link
Contributor Author

guarani commented Dec 14, 2021 •
edited
Loading

WPiOS 18.9.0.0 – Unsupported Block Editor tests

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password (⚠️ caveat: if Jetpack is installed and connected on the site, editing unsupported blocks is allowed)

Checklist taken from here.

@guarani
Copy link
Contributor Author

guarani commented Dec 14, 2021 •
edited
Loading

WPiOS 18.9.0.0 – Sanity tests

The sanity tests selected for this release are the following, Test suite 2 and Story block 1.

Test suite 2

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - AppenderButton is rendered - TC001
  • Group - Deep nesting is possible (iOS only) - TC002
  • Group - Check if Group placeholder is visible for the unselected state - TC003
  • Group - Check if Group placeholder is render in nested structure - TC004
  • Group - Nested block have proper border styling - TC005
  • Group - Nested block have proper margins values - TC006
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC008

Spacer - 1

  • Spacer block - Spacer is rendered without crash - TC001
  • Spacer block - Settings: Control spacer height using the slider - TC002
  • Spacer block - Settings: Control spacer height using the text input - TC003

Buttons-1

  • Buttons block - Buttons block is added with focused Button with gray background color and white text color - TC001
  • Buttons block - Buttons inline appender - TC002
  • Buttons block - Add another Button inside Buttons using inserter - TC003
  • Buttons block - Button's wrapper grows properly - TC023

Buttons-2

  • Buttons block - Removing Button along with Buttons block - TC004
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC005

Buttons-3

  • Buttons block - Wrapping Buttons - TC006
  • Buttons block - Buttons alignment options - TC007

Button-6

  • Buttons block - Settings: Open in new tab - TC011
  • Buttons block - Settings: Link rel - TC012
  • Buttons block - Settings: Link URL - TC010
  • Buttons block - Settings: Remove link - TC014
  • Buttons block - Settings: Synchronize with button options - TC013

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

  • Image block - Insert image from device (failing) - TC001
  • Image block - Insert image from device (cancel) - TC002
  • Image block - Add Caption - TC003
  • Image block - Close/Re-open post with an ongoing image upload - TC004
  • Image block - Close post with an ongoing image upload - TC005

Checklist taken from here.

Story block 1 tests

  • Story block - Verify is available in Block Picker - TC001
  • Story block - Verify is not available in Block Picker- TC002
  • Story block - Add media to empty Story block - TC003
  • Story block - Add media to non-empty Story block - TC004
  • Story block - Close/Re-open post with an ongoing Story upload - TC005

Checklist taken from here

@antonis
Copy link

antonis commented Dec 14, 2021 •
edited
Loading

🟢 Test Suite 5 - Android

Device: Pixel 5 / Android 12

Build: 18.9-rc-1 (1144) from Google Play

Video block - 1

  • Video block - Insert video from device (failing) - steps
  • Video block - Close/Re-open post with an ongoing video upload - steps

Video block - 2

  • Video block - Insert video from device (cancel) - steps
  • Video block - Close post with an ongoing video upload - steps
  • Video block - Add Caption - steps

File block - 1

  • File block - Upload completes successfully from the device library - steps
  • File block - Insert completes successfully from the WordPress Media library - steps
  • File block - Upload fails from the device library - steps
  • File block - Stop the file upload before it completes - steps

File block - 2

  • File block - Close the post with an ongoing file upload - steps
  • File block - Replace the selected files - steps
  • File block - Change the alignment in the File Block - steps
  • File block - The Link To Block Setting should open - steps

File block - 3

  • File block - Open link in new tab - steps
  • File block - Show/hide download button (Block Settings only) - steps
  • File block - Copy file URL - steps
  • File block - Close/Re-open post with an ongoing file upload - steps

Audio block - 1

  • Audio block - Upload completes successfully from the device library - steps
  • Audio block - Insert completes successfully from the WordPress Media library - steps

Audio block - 2

  • Audio block - Upload fails from the device library - steps
  • Audio block - Stop the audio file upload before it completes - steps

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - steps
  • Audio block - Replace the selected files - steps
  • Audio block - Change the alignment in the Audio Block - steps

Audio block - 4

  • Audio block - Autoplay setting - steps
  • Audio block - Loop setting - steps
  • Audio block - Close/Re-open post with an ongoing audio file upload - steps

Reusable block - 1

  • Reusable block - Add block - steps
  • Reusable block - Convert to regular blocks - steps

Reusable block - 2

  • Reusable block - Deleted reusable block - steps
  • Reusable block - Recursive block rendering - steps

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - steps

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - steps

@twstokes
Copy link
Contributor

twstokes commented Dec 14, 2021 •
edited
Loading

Writing Flow checklist - Android

Device: Pixel 4a
Build: 18.9-rc-1

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading ⚠️ When pressing Enter the second time to create the empty block in between, a newline was added to the top of the second heading. It required pressing Delete three times to merge the blocks. (Related issue + PR)
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@twstokes
Copy link
Contributor

twstokes commented Dec 14, 2021 •
edited
Loading

Unsupported Block Tests - Android

Device: Pixel 4a
Build: 18.9-rc-1

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack ⚠️ While waiting after pressing “Login with WordPress.com”, the message “Unable to load the block editor right now screen.” was shown, and then it loaded OK. This may cause confusion if the user doesn't notice that it's loading.
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@twstokes
Copy link
Contributor

twstokes commented Dec 14, 2021 •
edited
Loading

Sanity Test Suite 1 - Android

The test suites chosen for this release are Test Suite 1 and Test Suite 5.

Device: Pixel 4a
Build: 18.9-rc-1

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Columns percentage mechanism - column's preview - TC019
  • Columns - Columns percentage mechanism - column's slider input - TC020
  • Columns - Columns percentage mechanism - predefined percentage values are rendered correctly on frontend- TC021
  • Columns percentage mechanism - custom percentage values are rendered correctly on frontend- TC022
  • Columns - Multiple slider in columns parent - TC023
  • Columns - Adding Column with AppenderButton - TC003
  • Columns - Adding and removing Column with BottomSheet Stepper control - TC004

Columns - 2

  • Columns - Max limit of Column number - TC005
  • Columns - Min limit of Column number - TC006
  • Columns - Removing Column with remove button - TC007
  • Columns - Removing the only one left Column with remove button - TC008
  • Columns - Changing alignment on Columns - TC009
  • Columns - Changing alignment on individual Column - TC010
  • Columns - Alignment attribute is properly passed when adding Column - TC011
  • Columns - Deep nesting is possible (iOS only)- TC012

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - TC002
  • Columns - Appearance in vertical device position (vertical layout) - TC013
  • Columns - Appearance in horizontal device position (horizontal layout) - TC014
  • Columns - Mover direction - TC015
  • Columns - Check if Column placeholder is render in nested structure - TC016
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC017

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device (TC002) - steps
  • Media Text block - Insert image from device (TC002) - steps

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Change Minimum height in pixels - TC002
  • Cover - Change Background Opacity - TC009
  • Cover - Image focal point is rendered properly - TC003
  • Cover - Custom color is rendered properly - TC004

Editor Theme - 1

⚠️ The order of default colors and gradients appears to be opposite when comparing Android and iOS.

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003 ⚠️ Did not see custom colors from the Seedlet theme as an option. Issue created here.

Social Icons - 1

  • The newly created Social Icons block is added with 4 icons - TC001
  • Active icon gets product color - TC002
  • Only active icons are visible when not selected - TC003

@guarani
Copy link
Contributor Author

guarani commented Dec 14, 2021 •
edited
Loading

WPiOS 18.9.0.0 – Test new changes going into this release

@twstokes
Copy link
Contributor

twstokes commented Dec 15, 2021 •
edited
Loading

WP Android 18.9.0.0 – Test new changes going into this release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twstokes twstokes twstokes approved these changes

Assignees

No one assigned

Labels

release-process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@guarani @antonis @twstokes @fluiddot @SiobhyB @mkevins @dcalhoun