Feature/upload media file android #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
mzorz
reviewed
Jan 4, 2019
|
|
||
| void onMediaLibraryPress(MediaSelectedCallback mediaSelectedCallback); | ||
|
|
||
| void onUploadMediaPress(MediaUploadCallback mediaUploadCallback); |
Contributor
There was a problem hiding this comment.
Maybe we should follow the naming convention used in https://github.com/wordpress-mobile/WordPress-Android/pull/8879/files#diff-38b6aea9cfff5f3e0e4b7389b44de602R3185 and have the verb conjugation be in the past tense, i.e. onUploadMediaButtonClicked and onMediaLibraryButtonClicked, following the same pattern of on<EventHappened> as used in interface EditorFragmentListener
…le_ios_part_3 Makes the media id used on uploads an Int.
…captured_photo_android # Conflicts: # react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java
… where not needed or known
…erly replaced in RN
…edia_id Fix/upload media file media
…captured_photo_android # Conflicts: # react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java # react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
…oad_captured_photo_ios
…_photo_ios Upload captured photo ios
# Conflicts: # gutenberg # ios/gutenberg.xcodeproj/project.pbxproj # react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java # react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.m # react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.swift
…captured_photo_android # Conflicts: # gutenberg
…captured_photo_android # Conflicts: # gutenberg
…_photo_android Feature/upload captured photo android
# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map
SergioEstevao
approved these changes
Jan 25, 2019
Contributor
SergioEstevao
left a comment
SergioEstevao
left a comment
There was a problem hiding this comment.
Looking good, we will use other PR's to implement the error handling and the cancelation.
1 task
Contributor
|
@SergioEstevao please wait before merging - I was going to open a PR against this one. Will do against develop now, but please wait a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description :
This PR is introducing the logic for exchanging the data between JS side and Android side for purpose of uploading media file.
Test :
It is the part of the WPAndroid PR from which it can be tested.