Skip to content

Conversation

@sea212
Copy link
Contributor

@sea212 sea212 commented Sep 13, 2023

What does it do?

  • Contains version and weight updates.

What important points should reviewers know?

  • All changes already have been reviewed

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@sea212 sea212 added the s:review-needed The pull request requires reviews label Sep 13, 2023
@sea212 sea212 requested a review from Chralt98 September 13, 2023 15:40
@sea212 sea212 self-assigned this Sep 13, 2023
@sea212 sea212 changed the title Release v0.4.0 Merge release-v0.4.0 branch into main Sep 13, 2023
@sea212 sea212 added s:on-hold Work on the pull request has been paused and removed s:review-needed The pull request requires reviews labels Sep 19, 2023
maltekliemann and others added 3 commits September 19, 2023 21:01
* Update moonbeam dependencies (bench fix)

* Update weights
Include proof size into arbitrage weight estimates
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

This pull request is now in conflicts. Could you fix it @sea212? 🙏

@mergify mergify bot added the s:revision-needed The pull requests must be revised label Sep 27, 2023
@sea212 sea212 added s:in-progress The pull requests is currently being worked on and removed s:revision-needed The pull requests must be revised s:on-hold Work on the pull request has been paused labels Oct 10, 2023
@mergify mergify bot added s:revision-needed The pull requests must be revised and removed s:in-progress The pull requests is currently being worked on labels Oct 10, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:revision-needed The pull requests must be revised labels Oct 10, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (575ebec) 93.54% compared to head (e459e29) 93.44%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
- Coverage   93.54%   93.44%   -0.10%     
==========================================
  Files          96       96              
  Lines       29121    29530     +409     
==========================================
+ Hits        27240    27594     +354     
- Misses       1881     1936      +55     
Flag Coverage Δ
tests 93.44% <88.13%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
zrml/authorized/src/weights.rs 100.00% <100.00%> (ø)
zrml/global-disputes/src/weights.rs 100.00% <100.00%> (ø)
zrml/prediction-markets/src/lib.rs 85.03% <ø> (ø)
zrml/swaps/src/lib.rs 86.55% <76.92%> (-0.06%) ⬇️
zrml/liquidity-mining/src/weights.rs 0.00% <0.00%> (ø)
zrml/prediction-markets/src/weights.rs 96.91% <96.75%> (-0.07%) ⬇️
zrml/styx/src/weights.rs 0.00% <0.00%> (ø)
zrml/court/src/weights.rs 79.03% <79.78%> (+0.12%) ⬆️
zrml/swaps/src/weights.rs 83.55% <83.54%> (-1.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea212 sea212 merged commit fdda998 into main Oct 11, 2023
@sea212 sea212 deleted the release-v0.4.0 branch October 11, 2023 11:56
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Oct 11, 2023
@sea212 sea212 restored the release-v0.4.0 branch October 17, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s:accepted This pull request is ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants