Reduce length of MarketsCollectingSubsidy
#1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea212
approved these changes
Sep 19, 2023
Contributor
sea212
left a comment
sea212
left a comment
There was a problem hiding this comment.
Standalone chain accepts tx after updating weights.
Will prepare update weight PR and test tx on local parachain network.
sea212
added a commit
that referenced
this pull request
Oct 11, 2023
* Update versions to v0.4.0 (#1098) * Update weights (#1101) * Reduce length of `MarketsCollectingSubsidy` (#1118) * Add bad block of the proof size fiasko to Battery Station chain spec (#1119) Add bad block to Battery Station chain spec * Update weights v0.4.0 (#1121) * Update moonbeam dependencies (bench fix) * Update weights * Adapt arbitrage weight calculations to proof sizes (#1120) Include proof size into arbitrage weight estimates --------- Co-authored-by: Malte Kliemann <[email protected]>
maltekliemann
added a commit
that referenced
this pull request
Oct 11, 2023
* Implement neo-swaps * Fix compile issues * Implement `DeployPoolsApi` as noop * Fix formatting * Add missing copyright notices * Fix clippy issues * Fix more clippy issues and rename `balances` to `reserves` * Remove `println!` * Add missing copyright notice * . * Add benchmarking and include `NeoSwaps` in Runtime * Add neo-swaps benchmarks; remove `split` (for now) * Add benchmarks for `create_market_and_deploy_pool` * Properly implement `DeployPool` * Fix benchmarks, remove unnecessary parameter * Fix formatting * Fix dependencies * Add math docs * Fix typo * Make me codeowner of neo-swaps * Add neo-swaps to main README and fix link to PDF * Fix link * Update versions to v0.4.0 (#1098) * Update weights (#1101) * Remove unnecessary comment from toml * Use default features * Bump version * Use checked math in `SoloLp` * Make match expression explicit * Add comment about saturation * Use `MultiCurrency` instead of `ZeitgeistAssetManager` * Apply suggestions from code review Co-authored-by: Harald Heckmann <[email protected]> * Remove superfluous inserts * Fix error documentation * Abstract reserve updates into `Pool` * Make complete set operations require transactional * Make test name not coffee-based * Update zrml/neo-swaps/src/mock.rs Co-authored-by: Harald Heckmann <[email protected]> * Update zrml/neo-swaps/src/mock.rs Co-authored-by: Harald Heckmann <[email protected]> * Reorganize tests * Format * Fix comment * Remove `macros.rs` * Fix benchmarks * Fix formatting * Update benchmark script and add preliminary benchmarks * Update ED buffer handling * Fix documentation * Implement market creation fees for neo-swaps * Use `MarketCreatorFee` in runtime * Add missing files * Add weights * Reduce length of `MarketsCollectingSubsidy` (#1118) * Add bad block of the proof size fiasko to Battery Station chain spec (#1119) Add bad block to Battery Station chain spec * Update weights v0.4.0 (#1121) * Update moonbeam dependencies (bench fix) * Update weights * Fix docs * Rename `IndexType` and change its type value * Remove commented code * Fix order of config parameters * Specify order of assets * Remove commented code * Apply suggestions from code review Co-authored-by: Chralt <[email protected]> * Fix `u16`/`u32` casts * Update zrml/prediction-markets/src/benchmarks.rs Co-authored-by: Chralt <[email protected]> * Update zrml/prediction-markets/src/benchmarks.rs Co-authored-by: Chralt <[email protected]> * Update zrml/neo-swaps/src/math.rs Co-authored-by: Chralt <[email protected]> * Update primitives/src/math/fixed.rs Co-authored-by: Chralt <[email protected]> * Update primitives/src/math/fixed.rs Co-authored-by: Chralt <[email protected]> * Fix formatting * Fix conflicts * Fix dispute period * Format code --------- Co-authored-by: Harald Heckmann <[email protected]> Co-authored-by: Chralt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Shortens the length of
MarketsCollectingSubsidyto ensure that benchmarks don't overestimate the required proof size ofon_initialize, which has led to local nodes and Battery Station becoming unresponsive.What important points should reviewers know?
Reviewers should diligently check that all benchmark results except for
pallet_parachain_staking::delegate_with_auto_compoundare not sufficiently small and that the local node accepts transactions.Is there something left for follow-up PRs?
Figure out why the benchmark of
delegate_with_auto_compoundis broken.What alternative implementations were considered?
Are there relevant PRs or issues?
from_ref_timefor weights after the relevant polkadot version paritytech/polkadot-sdk#1589References